From: Paul Mundt <lethal@linux-sh.org>
To: Samuel Ortiz <sameo@linux.intel.com>
Cc: Linus Torvalds <torvalds@linux-foundation.org>,
linux-kernel <linux-kernel@vger.kernel.org>,
Peter Huewe <peterhuewe@gmx.de>,
Randy Dunlap <randy.dunlap@oracle.com>,
Denis Turischev <denis@compulab.co.il>,
Mark Brown <broonie@opensource.wolfsonmicro.com>,
Mike Turquette <mturquette@ti.com>,
Magnus Damm <damm@opensource.se>,
Yusuke Goda <goda.yusuke@renesas.com>,
Guennadi Liakhovetski <g.liakhovetski@gmx.de>,
Balaji T K <balajitk@ti.com>, Moiz Sonasath <m-sonasath@ti.com>,
Eduardo Valentin <eduardo.valentin@nokia.com>,
Haojian Zhuang <haojian.zhuang@marvell.com>,
Joonyoung Shim <jy0922.shim@samsung.com>,
Christoph Egger <siccegge@stud.informatik.uni-erlangen.de>,
Linus Walleij <linus.walleij@stericsson.com>,
Cory Maccarrone <darkstar6262@gmail.com>,
Julia Lawall <julia@diku.dk>,
H Hartley Sweeten <hartleys@visionengravers.com>
Subject: Re: [GIT PULL] MFD update for 2.6.34
Date: Mon, 8 Mar 2010 20:48:36 +0900 [thread overview]
Message-ID: <20100308114835.GA16081@linux-sh.org> (raw)
In-Reply-To: <20100307215323.GA21970@sortiz.org>
On Sun, Mar 07, 2010 at 10:53:25PM +0100, Samuel Ortiz wrote:
> H Hartley Sweeten (3):
> mfd: Use resource_size() in sm501
> mfd: Use resource_size() for t7l66xb
> mfd: Use resouce_size for tc6393xb
>
These need to be looked at carefully, at least the sm501 change is
totally bogus, breaks everything, and stems from a total lack of
understanding of how the drivers interact.
The I/O resource that's remapped and handled by the MFD takes the full
size, while the region request is purposely trimmed down so only the
registers needed by the MFD driver are reserved by the MFD driver. Other
drivers (like sm501fb) will have their own region requests within the
same resource at different offsets, all of which are broken after this
change.
As such, 311e54c07e784fe63d421f724dcc597d1f82ccad at least needs to be
reverted. I haven't looked at the other two, but if it's a similar
mechanical change then those should be dropped, too.
next prev parent reply other threads:[~2010-03-08 11:49 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-03-07 21:53 [GIT PULL] MFD update for 2.6.34 Samuel Ortiz
2010-03-08 11:48 ` Paul Mundt [this message]
2010-03-08 15:20 ` H Hartley Sweeten
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20100308114835.GA16081@linux-sh.org \
--to=lethal@linux-sh.org \
--cc=balajitk@ti.com \
--cc=broonie@opensource.wolfsonmicro.com \
--cc=damm@opensource.se \
--cc=darkstar6262@gmail.com \
--cc=denis@compulab.co.il \
--cc=eduardo.valentin@nokia.com \
--cc=g.liakhovetski@gmx.de \
--cc=goda.yusuke@renesas.com \
--cc=haojian.zhuang@marvell.com \
--cc=hartleys@visionengravers.com \
--cc=julia@diku.dk \
--cc=jy0922.shim@samsung.com \
--cc=linus.walleij@stericsson.com \
--cc=linux-kernel@vger.kernel.org \
--cc=m-sonasath@ti.com \
--cc=mturquette@ti.com \
--cc=peterhuewe@gmx.de \
--cc=randy.dunlap@oracle.com \
--cc=sameo@linux.intel.com \
--cc=siccegge@stud.informatik.uni-erlangen.de \
--cc=torvalds@linux-foundation.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox