public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
* [PATCH] Inotify: Fix build failure in inotify user support
@ 2010-03-08 19:51 Ralf Baechle
  2010-04-30 17:04 ` Ralf Baechle
  0 siblings, 1 reply; 3+ messages in thread
From: Ralf Baechle @ 2010-03-08 19:51 UTC (permalink / raw)
  To: Linus Torvalds, Al Viro; +Cc: linux-kernel

CONFIG_INOTIFY_USER defined but CONFIG_ANON_INODES undefined will result
in the following build failure:

  LD      vmlinux
fs/built-in.o: In function 'sys_inotify_init1':
(.text.sys_inotify_init1+0x22c): undefined reference to 'anon_inode_getfd'
fs/built-in.o: In function `sys_inotify_init1':
(.text.sys_inotify_init1+0x22c): relocation truncated to fit: R_MIPS_26 against 'anon_inode_getfd'
make[2]: *** [vmlinux] Error 1
make[1]: *** [sub-make] Error 2
make: *** [all] Error 2

Signed-off-by: Ralf Baechle <ralf@linux-mips.org>
To: Al Viro <viro@zeniv.linux.org.uk>
Cc: linux-kernel@linux-kernel.org

 fs/notify/inotify/Kconfig |    1 +
 1 files changed, 1 insertions(+), 0 deletions(-)

diff --git a/fs/notify/inotify/Kconfig b/fs/notify/inotify/Kconfig
index 3e56dbf..b3a159b 100644
--- a/fs/notify/inotify/Kconfig
+++ b/fs/notify/inotify/Kconfig
@@ -15,6 +15,7 @@ config INOTIFY
 
 config INOTIFY_USER
 	bool "Inotify support for userspace"
+	select ANON_INODES
 	select FSNOTIFY
 	default y
 	---help---

^ permalink raw reply related	[flat|nested] 3+ messages in thread

* Re: [PATCH] Inotify: Fix build failure in inotify user support
  2010-03-08 19:51 [PATCH] Inotify: Fix build failure in inotify user support Ralf Baechle
@ 2010-04-30 17:04 ` Ralf Baechle
  2010-05-04  8:09   ` Florian Fainelli
  0 siblings, 1 reply; 3+ messages in thread
From: Ralf Baechle @ 2010-04-30 17:04 UTC (permalink / raw)
  To: Linus Torvalds, Al Viro; +Cc: linux-kernel

On Mon, Mar 08, 2010 at 08:51:03PM +0100, Ralf Baechle wrote:

> CONFIG_INOTIFY_USER defined but CONFIG_ANON_INODES undefined will result
> in the following build failure:
> 
>   LD      vmlinux
> fs/built-in.o: In function 'sys_inotify_init1':
> (.text.sys_inotify_init1+0x22c): undefined reference to 'anon_inode_getfd'
> fs/built-in.o: In function `sys_inotify_init1':
> (.text.sys_inotify_init1+0x22c): relocation truncated to fit: R_MIPS_26 against 'anon_inode_getfd'
> make[2]: *** [vmlinux] Error 1
> make[1]: *** [sub-make] Error 2
> make: *** [all] Error 2

Ping.  The problem still exists in rc6.

  Ralf

^ permalink raw reply	[flat|nested] 3+ messages in thread

* Re: [PATCH] Inotify: Fix build failure in inotify user support
  2010-04-30 17:04 ` Ralf Baechle
@ 2010-05-04  8:09   ` Florian Fainelli
  0 siblings, 0 replies; 3+ messages in thread
From: Florian Fainelli @ 2010-05-04  8:09 UTC (permalink / raw)
  To: Ralf Baechle; +Cc: Linus Torvalds, Al Viro, linux-kernel

Hi,

On Friday 30 April 2010 19:04:31 Ralf Baechle wrote:
> On Mon, Mar 08, 2010 at 08:51:03PM +0100, Ralf Baechle wrote:
> > CONFIG_INOTIFY_USER defined but CONFIG_ANON_INODES undefined will result
> > 
> > in the following build failure:
> >   LD      vmlinux
> > 
> > fs/built-in.o: In function 'sys_inotify_init1':
> > (.text.sys_inotify_init1+0x22c): undefined reference to
> > 'anon_inode_getfd' fs/built-in.o: In function `sys_inotify_init1':
> > (.text.sys_inotify_init1+0x22c): relocation truncated to fit: R_MIPS_26
> > against 'anon_inode_getfd' make[2]: *** [vmlinux] Error 1
> > make[1]: *** [sub-make] Error 2
> > make: *** [all] Error 2
> 
> Ping.  The problem still exists in rc6.

Ralf's patch fixes the issue for me.


^ permalink raw reply	[flat|nested] 3+ messages in thread

end of thread, other threads:[~2010-05-04  8:10 UTC | newest]

Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2010-03-08 19:51 [PATCH] Inotify: Fix build failure in inotify user support Ralf Baechle
2010-04-30 17:04 ` Ralf Baechle
2010-05-04  8:09   ` Florian Fainelli

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox