From: Al Viro <viro@ZenIV.linux.org.uk>
To: Eric Paris <eparis@redhat.com>
Cc: torvalds@linux-foundation.org, linux-kernel@vger.kernel.org
Subject: Re: [GIT PULL] notification: after one week
Date: Mon, 8 Mar 2010 21:57:48 +0000 [thread overview]
Message-ID: <20100308215748.GO30031@ZenIV.linux.org.uk> (raw)
In-Reply-To: <1268081739.3227.5.camel@localhost>
On Mon, Mar 08, 2010 at 03:55:39PM -0500, Eric Paris wrote:
> Having you tell me to wait a week after rebasing (and probably being the
> only person who waited a week after rebasing to ask for a pull) I'm
> back. I hoped to hear some review but none came. If it does, rest
> assured addressing those issues will be my top priority. Since the last
> pull request the only change is that I corrected the build flags to not
> add -Wsigned-pointer and I actually dropped the permissions bits from
> this branch (those bits are and have been in linux-next for a long time
> now as well though)
Sigh... I *will* dig the full review out (been buried in autofs review
lately), but for starters grep for fsnotify() and fsnotify_parent(),
then tell me why on the earth are you doing that kind of insane multiplexors?
I mean, WTF?
; git grep -n -w fsnotify_parent
include/linux/fsnotify.h:28:static inline void fsnotify_parent(struct path *path, struct dentry
include/linux/fsnotify.h:115: fsnotify_parent(NULL, dentry, mask);
include/linux/fsnotify.h:176: fsnotify_parent(path, NULL, mask);
include/linux/fsnotify.h:194: fsnotify_parent(path, NULL, mask);
include/linux/fsnotify.h:212: fsnotify_parent(path, NULL, mask);
include/linux/fsnotify.h:231: fsnotify_parent(path, NULL, mask);
include/linux/fsnotify.h:247: fsnotify_parent(NULL, dentry, mask);
include/linux/fsnotify.h:282: fsnotify_parent(NULL, dentry, mask);
;
and *ALL* callers get one of those NULL and another non-NULL. With
different behaviour inside that sucker. And fsnotify() is no better -
it's a multiplexor from hell.
next prev parent reply other threads:[~2010-03-08 21:57 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-03-08 20:55 [GIT PULL] notification: after one week Eric Paris
2010-03-08 21:57 ` Al Viro [this message]
2010-03-08 22:45 ` Eric Paris
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20100308215748.GO30031@ZenIV.linux.org.uk \
--to=viro@zeniv.linux.org.uk \
--cc=eparis@redhat.com \
--cc=linux-kernel@vger.kernel.org \
--cc=torvalds@linux-foundation.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox