* [PATCH] mfd: Fix sm501 requested region size
@ 2010-03-09 8:09 Samuel Ortiz
2010-03-09 10:48 ` Paul Mundt
2010-03-09 16:50 ` H Hartley Sweeten
0 siblings, 2 replies; 3+ messages in thread
From: Samuel Ortiz @ 2010-03-09 8:09 UTC (permalink / raw)
To: linux-kernel; +Cc: Paul Mundt, H Hartley Sweeten
We should only request for the MFD used region, not the whole thing.
Signed-off-by: Samuel Ortiz <sameo@linux.intel.com>
---
drivers/mfd/sm501.c | 4 ++--
1 files changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/mfd/sm501.c b/drivers/mfd/sm501.c
index dc9ea95..497712f 100644
--- a/drivers/mfd/sm501.c
+++ b/drivers/mfd/sm501.c
@@ -1430,7 +1430,7 @@ static int __devinit sm501_plat_probe(struct platform_device *dev)
}
sm->regs_claim = request_mem_region(sm->io_res->start,
- resource_size(sm->io_res), "sm501");
+ 0x100, "sm501");
if (sm->regs_claim == NULL) {
dev_err(&dev->dev, "cannot claim registers\n");
@@ -1644,7 +1644,7 @@ static int __devinit sm501_pci_probe(struct pci_dev *dev,
sm->mem_res = &dev->resource[0];
sm->regs_claim = request_mem_region(sm->io_res->start,
- resource_size(sm->io_res), "sm501");
+ 0x100, "sm501");
if (sm->regs_claim == NULL) {
dev_err(&dev->dev, "cannot claim registers\n");
err= -EBUSY;
--
1.6.3.3
--
Intel Open Source Technology Centre
http://oss.intel.com/
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH] mfd: Fix sm501 requested region size
2010-03-09 8:09 [PATCH] mfd: Fix sm501 requested region size Samuel Ortiz
@ 2010-03-09 10:48 ` Paul Mundt
2010-03-09 16:50 ` H Hartley Sweeten
1 sibling, 0 replies; 3+ messages in thread
From: Paul Mundt @ 2010-03-09 10:48 UTC (permalink / raw)
To: Samuel Ortiz; +Cc: linux-kernel, H Hartley Sweeten
On Tue, Mar 09, 2010 at 09:09:54AM +0100, Samuel Ortiz wrote:
>
> We should only request for the MFD used region, not the whole thing.
>
> Signed-off-by: Samuel Ortiz <sameo@linux.intel.com>
Works for me, thanks.
Tested-by: Paul Mundt <lethal@linux-sh.org>
^ permalink raw reply [flat|nested] 3+ messages in thread
* RE: [PATCH] mfd: Fix sm501 requested region size
2010-03-09 8:09 [PATCH] mfd: Fix sm501 requested region size Samuel Ortiz
2010-03-09 10:48 ` Paul Mundt
@ 2010-03-09 16:50 ` H Hartley Sweeten
1 sibling, 0 replies; 3+ messages in thread
From: H Hartley Sweeten @ 2010-03-09 16:50 UTC (permalink / raw)
To: Samuel Ortiz, linux-kernel; +Cc: Paul Mundt
On Tuesday, March 09, 2010 1:10 AM, Samuel Ortiz wrote:
>
> We should only request for the MFD used region, not the whole thing.
>
> Signed-off-by: Samuel Ortiz <sameo@linux.intel.com>
Reviewed-by: H Hartley Sweeten <hsweeten@visionengravers.com>
Sorry about that...
> ---
> drivers/mfd/sm501.c | 4 ++--
> 1 files changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/mfd/sm501.c b/drivers/mfd/sm501.c
> index dc9ea95..497712f 100644
> --- a/drivers/mfd/sm501.c
> +++ b/drivers/mfd/sm501.c
> @@ -1430,7 +1430,7 @@ static int __devinit sm501_plat_probe(struct platform_device *dev)
> }
>
> sm->regs_claim = request_mem_region(sm->io_res->start,
> - resource_size(sm->io_res), "sm501");
> + 0x100, "sm501");
>
> if (sm->regs_claim == NULL) {
> dev_err(&dev->dev, "cannot claim registers\n");
> @@ -1644,7 +1644,7 @@ static int __devinit sm501_pci_probe(struct pci_dev *dev,
> sm->mem_res = &dev->resource[0];
>
> sm->regs_claim = request_mem_region(sm->io_res->start,
> - resource_size(sm->io_res), "sm501");
> + 0x100, "sm501");
> if (sm->regs_claim == NULL) {
> dev_err(&dev->dev, "cannot claim registers\n");
> err= -EBUSY;
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2010-03-09 16:59 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2010-03-09 8:09 [PATCH] mfd: Fix sm501 requested region size Samuel Ortiz
2010-03-09 10:48 ` Paul Mundt
2010-03-09 16:50 ` H Hartley Sweeten
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).