* [PATCH -mm 3/3] call_usermodehelper: UMH_WAIT_EXEC ignores kernel_thread() failure
@ 2010-03-09 21:45 Oleg Nesterov
0 siblings, 0 replies; only message in thread
From: Oleg Nesterov @ 2010-03-09 21:45 UTC (permalink / raw)
To: Andrew Morton
Cc: Andi Kleen, David Howells, Neil Horman, Rusty Russell,
linux-kernel
UMH_WAIT_EXEC should report the error if kernel_thread() fails, like
UMH_WAIT_PROC does.
Signed-off-by: Oleg Nesterov <oleg@redhat.com>
---
kernel/kmod.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
--- mm/kernel/kmod.c~3_UMH_WAIT_EXEC 2010-03-09 21:56:36.000000000 +0100
+++ mm/kernel/kmod.c 2010-03-09 22:23:37.000000000 +0100
@@ -254,10 +254,10 @@ static void __call_usermodehelper(struct
case UMH_WAIT_PROC:
if (pid > 0)
break;
- sub_info->retval = pid;
/* FALLTHROUGH */
-
case UMH_WAIT_EXEC:
+ if (pid < 0)
+ sub_info->retval = pid;
complete(sub_info->complete);
}
}
^ permalink raw reply [flat|nested] only message in thread
only message in thread, other threads:[~2010-03-09 21:47 UTC | newest]
Thread overview: (only message) (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2010-03-09 21:45 [PATCH -mm 3/3] call_usermodehelper: UMH_WAIT_EXEC ignores kernel_thread() failure Oleg Nesterov
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox