From: Greg KH <greg@kroah.com>
To: Samuel Thibault <samuel.thibault@ens-lyon.org>,
linux-kernel@vger.kernel.org, lenz@cs.wisc.edu,
rpurdie@openedhand.com
Subject: Re: private field in led_classdev?
Date: Tue, 9 Mar 2010 18:54:11 -0800 [thread overview]
Message-ID: <20100310025411.GD26642@kroah.com> (raw)
In-Reply-To: <20100307143112.GC5203@const.famille.thibault.fr>
On Sun, Mar 07, 2010 at 03:31:12PM +0100, Samuel Thibault wrote:
> Hello,
>
> Would there be an objection to adding a void *private field to the
> led_classdev struct? It would be a lot less burden for the input
> key board leds support for finding out the keyboard device from the
> brightness_set callback, as each device may have a long series of leds,
> not just a fixed number of them.
What's wrong with using the private pointer in the struct device
instead? That's what it is there for.
thanks,
greg k-h
next prev parent reply other threads:[~2010-03-10 3:16 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-03-07 14:31 private field in led_classdev? Samuel Thibault
2010-03-10 2:54 ` Greg KH [this message]
2010-03-10 9:44 ` Samuel Thibault
2010-03-10 11:01 ` Samuel Thibault
2010-03-17 12:48 ` Richard Purdie
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20100310025411.GD26642@kroah.com \
--to=greg@kroah.com \
--cc=lenz@cs.wisc.edu \
--cc=linux-kernel@vger.kernel.org \
--cc=rpurdie@openedhand.com \
--cc=samuel.thibault@ens-lyon.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox