linux-kernel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Paul Mundt <lethal@linux-sh.org>
To: Greg KH <greg@kroah.com>
Cc: Magnus Damm <damm@opensource.se>,
	linux-kernel@vger.kernel.org, linux-sh@vger.kernel.org
Subject: Re: [PATCH] driver core: Early dev_name() support.
Date: Wed, 10 Mar 2010 12:21:58 +0900	[thread overview]
Message-ID: <20100310032158.GA19518@linux-sh.org> (raw)
In-Reply-To: <20100310023727.GB26642@kroah.com>

On Tue, Mar 09, 2010 at 06:37:27PM -0800, Greg KH wrote:
> On Tue, Mar 09, 2010 at 03:57:53PM +0900, Paul Mundt wrote:
> > Presently early platform devices suffer from the fact they are unable to
> > use dev_xxx() calls early on due to dev_name() and others being
> > unavailable at the time ->probe() is called.
> > 
> > This implements early init_name construction from the matched name/id
> > pair following the semantics of the late device/driver match. As a
> > result, matched IDs (inclusive of requested ones) are preserved when the
> > handoff from the early platform code happens at kobject initialization
> > time.
> > 
> > Since we still require kmalloc slabs to be available at this point, using
> > kstrdup() for establishing the init_name works fine. This subsequently
> > needs to be tested from dev_name() prior to the init_name being cleared
> > by the driver core. We don't kfree() since others will already have a
> > handle on the string long before the kobject initialization takes place.
> > 
> > This is also needed to permit drivers to use the clock framework early,
> > without having to manually construct their own device IDs from the match
> > id/name pair locally (needed by the early console and timer code on sh
> > and arm).
> 
> Is this change something that we need for .34?  Or can it wait for .35?
> 
If it went in for .34 we would get properly dev_name() resolution in the
error paths for the existing early platform drivers, but that's obviously
not critical.

I have a bunch of work I plan to do on top of it for 2.6.35, so I was
planning on carrying it in a topic branch once I got your Acked-by.

  reply	other threads:[~2010-03-10  3:22 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2010-03-09  6:57 [PATCH] driver core: Early dev_name() support Paul Mundt
2010-03-10  2:37 ` Greg KH
2010-03-10  3:21   ` Paul Mundt [this message]
2010-03-10  3:28     ` Greg KH
2010-03-10  4:10       ` Paul Mundt
2010-03-11 19:59 ` Kay Sievers
2010-03-15  8:03   ` Paul Mundt
2010-03-15 11:29     ` Kay Sievers
2010-03-15 11:56       ` Paul Mundt

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20100310032158.GA19518@linux-sh.org \
    --to=lethal@linux-sh.org \
    --cc=damm@opensource.se \
    --cc=greg@kroah.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-sh@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).