Re: [PATCH vfat] allow retrieving entries with trailing dots

OGAWA Hirofumi
2010-03-10T17:16:32Z

Philippe De Muyter <phdm@macqel.be> writes:

>> This introduces unneeded directory-parse to standard one. And for
>
> No. There will only be a second parse if someone is looking for a filename
> with a trailing dot, and it is not found (*). I there is no trailing dot in qname, only the first fat_search_long will be called, because len after vfat_striptail_len would be equal to qname->len.

Yes, I'm saying about trailing-dot filename case. Any disadvantage to
standard one is unacceptable to workaround.

>> IO-MEGA, this wouldn't provide proper filename handling.
>
> For accessing IO-MEGA disk in read mode, this is perfect. I didn't want
> to replicate IO-MEGA write behaviour here, only fix the read behaviour for
> such simple commands as 'ls', 'find' and all the directory browsers.
>
>> If it wants to handle the tailing-dot as a part of filename, it
>> shouldn't be able to access to the stripped-dots filename. (For simple
>> example, I guess you can't do "mv a a." with this patch.)
>
> As I explained above, I only fix read-access on IO-MEGA drives, while
> preserving standard behaviour for write mode.
>
> But I'll try your testcase asap. Which behaviour do you expect ?
> I would expect a no-op, because I did not change the write-behaviour.

Those sound like strange. Well, I expect there is no any change to
standard one for IO-MEGA.

And I can't see what is your read-access mean in here. What did this
expect to behave like e.g. following operations,

$ ls
a.. a. a
$ rm -rf *

$ ls
a..
$ touch a.
$ touch a
...

I assumed you want to define "a." and "a" are different name on
"mv a a.", and _totally_.

Thanks.
--
OGAWA Hirofumi <hirofumi@mail.parknet.co.jp>