Re: [PATCH vfat] allow retrieving entries with trailing dots

OGAWA Hirofumi
2010-03-11T09:26:59Z

Philippe De Muyter <phdm@macqel.be> writes:

>> >> This introduces unneeded directory-parse to standard one. And for
>> >
>> > No. There will only be a second parse if someone is looking for a filename
>> > with a trailing dot, and it is not found (*). I there is no trailing dot in qname, only the first fat_search_long will be called, because len after vfat_striptail_len would be equal to qname->len.
>>
>> Yes, I'm saying about trailing-dot filename case. Any disadvantage to
>> standard one is unacceptable to workaround.
>
> This is unavoidable.

We would be able to introduce new mount option to do it if needed.

>> $ ls
>> a.. a. a
>> $ rm -rf *
>>
>> $ ls
>> a..
>> $ touch a.
>> $ touch a
>> ...
>>
>> I assumed you want to define "a." and "a" are different name on
>> "mv a a.", and _totally_.
>
> For file creation and renaming, I want to introduce no change, because there
> is no problem. If one wants to create a "a." file on a IO-MEGA disk suing
> linux and USB, it is currently called "a", and that will remain exactly the
> same.

This changed vfat_find(), so, this patch will change the behavior of all
callers more or less. And the behavior seems to be really strange, you
can remove "a.", but you can't create it? The behavior sounds random,
right?

Thanks.
--
OGAWA Hirofumi <hirofumi@mail.parknet.co.jp>