Re: [PATCH vfat] IOMEGA network drive compatibility

OGAWA Hirofumi
2010-03-14T14:52:57Z

Philippe De Muyter <phdm@macqel.be> writes:

>> Because it's wrong entry as fatfs. In this situation, user needs to
>> repair by tools (e.g. fsck), so it's not responsibility of fs driver.
>
> I know that entries with trailing dots are "invalid" fatfs entries,
> but 1) linux/vfat currently accept such entries silently without truncating
> them and 2) IOMEGA disks present themselves as fatfs disks. Who are we to
> tell the opposite ? And IOMEGA integrated scandisk (accessible via the
> web interface) does not find any error in its filesystem.

You can create many files points to one cluster chain. It is silently
accepted by current fatfs driver. But, it's a broken fs image like this.

>> Now, you try to change that design. So, you need to change/think more
>> high level consistency/design, not just workaround. Otherwise, it'll be
>> unmaintainable/unfixable.
>
> I am sorry but I don't see anything unmaintainable/unfixable in my patch :
> it is very small and localized and it only allows accessing existing
> entries with trailing dots, nothing more.
>
> It does not allow to create "invalid" entries, so it does not change the
> behaviour for "strict" vfat disks, it only introduces a small time penalty
> when a user tries to access a file using a different name that the one stored
> in the directory, which happens very rarely : most linux users use GUI's or
> bash tab-completion to access files, which implies they use the name given by
> the file-system driver, not a variation of it.
>
> Now if we are concerned about "editing" such files by creating a temporary
> file and renaming, we can look at what is needed to make renaming to an
> existing name containing trailing dots succeed. I have not tested that yet.
>
> For the rest, i.e. creating arbitrary names with trailing dots just like
> what IOMEGA drives do, it can be with a mount option, or left as it is
> now : impossible.

I already reported the one of bugs at least, and it seems you already
can't fix it, or just ignored it.

You are always saying "I'm fine with this". But I disagree, and I know
this fs is not only for just desktop users. If this is only for you
usage, I'm sorry, but please apply it yourself.

Thanks.
--
OGAWA Hirofumi <hirofumi@mail.parknet.co.jp>