From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S932494Ab0CJRHV (ORCPT ); Wed, 10 Mar 2010 12:07:21 -0500 Received: from opensource.wolfsonmicro.com ([80.75.67.52]:56228 "EHLO opensource2.wolfsonmicro.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S932478Ab0CJRHU (ORCPT ); Wed, 10 Mar 2010 12:07:20 -0500 Date: Wed, 10 Mar 2010 17:07:17 +0000 From: Mark Brown To: axel lin Cc: linux-kernel , Marek Szyprowski , Kyungmin Park , lrg@slimlogic.co.uk Subject: Re: [PATCH] Regulators: lp3971 - Fix setting val for LDO2 and LDO4 Message-ID: <20100310170717.GC22626@rakim.wolfsonmicro.main> References: <427d64721003091629s4c5728b4y9005feeef9a05b7e@mail.gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <427d64721003091629s4c5728b4y9005feeef9a05b7e@mail.gmail.com> X-Cookie: Love means nothing to a tennis player. User-Agent: Mutt/1.5.20 (2009-06-14) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, Mar 10, 2010 at 08:29:40AM +0800, axel lin wrote: > From: Axel Lin > Date: Tue, 9 Mar 2010 16:53:59 +0800 > Subject: [PATCH] lp3971: Fix setting val for LDO2 and LDO4 > > In lp3971_ldo_set_voltage function, it requires val to left shift 4 > bits for LDO2 and LDO4. > This patch fix this issue. > > Signed-off-by: Axel Lin Acked-by: Mark Brown but I really would prefer to see one of the Samsung folks comment.