From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
	id S1757424Ab0CJXAr (ORCPT <rfc822;w@1wt.eu>);
	Wed, 10 Mar 2010 18:00:47 -0500
Received: from cantor2.suse.de ([195.135.220.15]:43053 "EHLO mx2.suse.de"
	rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP
	id S1757385Ab0CJXAq (ORCPT <rfc822;linux-kernel@vger.kernel.org>);
	Wed, 10 Mar 2010 18:00:46 -0500
Date: Wed, 10 Mar 2010 14:58:41 -0800
From: Greg KH <gregkh@suse.de>
To: David Rientjes <rientjes@google.com>
Cc: linux-kernel@vger.kernel.org
Subject: Re: [patch] numa: fix BUILD_BUG_ON for node_read_distance
Message-ID: <20100310225841.GA6536@suse.de>
References: <alpine.DEB.2.00.1003101449480.21849@chino.kir.corp.google.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <alpine.DEB.2.00.1003101449480.21849@chino.kir.corp.google.com>
User-Agent: Mutt/1.5.20 (2009-06-14)
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On Wed, Mar 10, 2010 at 02:50:21PM -0800, David Rientjes wrote:
> node_read_distance() has a BUILD_BUG_ON() to prevent buffer overruns when
> the number of nodes printed will exceed the buffer length.
> 
> Each node only needs four chars: three for distance (maximum distance is
> 255) and one for a seperating space or a trailing newline.

Is this causing a problem as-is today that we need to resolve for
2.6.34?  Or is this 2.6.35 material?

Who chose this original number, and why is it off by 1/2?

thanks,

greg k-h