From: Greg KH <gregkh@suse.de>
To: David Rientjes <rientjes@google.com>
Cc: linux-kernel@vger.kernel.org
Subject: Re: [patch] numa: fix BUILD_BUG_ON for node_read_distance
Date: Wed, 10 Mar 2010 15:11:16 -0800 [thread overview]
Message-ID: <20100310231116.GA6797@suse.de> (raw)
In-Reply-To: <alpine.DEB.2.00.1003101501330.15549@chino.kir.corp.google.com>
On Wed, Mar 10, 2010 at 03:05:47PM -0800, David Rientjes wrote:
> On Wed, 10 Mar 2010, Greg KH wrote:
>
> > > node_read_distance() has a BUILD_BUG_ON() to prevent buffer overruns when
> > > the number of nodes printed will exceed the buffer length.
> > >
> > > Each node only needs four chars: three for distance (maximum distance is
> > > 255) and one for a seperating space or a trailing newline.
> >
> > Is this causing a problem as-is today that we need to resolve for
> > 2.6.34? Or is this 2.6.35 material?
> >
>
> It's not needed at least for x86 for 2.6.34 since the max
> CONFIG_NODES_SHIFT is 9. I don't know about other architectures with
> different ranges or page sizes.
>
> I'm going to push a change to the x86 maintainers to increase that max
> CONFIG_NODES_SHIFT to 10 hopefully for 2.6.35, that's where we run into
> this error.
Ok, I'll queue this up for .35, thanks.
greg k-h
prev parent reply other threads:[~2010-03-10 23:13 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-03-10 22:50 [patch] numa: fix BUILD_BUG_ON for node_read_distance David Rientjes
2010-03-10 22:58 ` Greg KH
2010-03-10 23:05 ` David Rientjes
2010-03-10 23:11 ` Greg KH [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20100310231116.GA6797@suse.de \
--to=gregkh@suse.de \
--cc=linux-kernel@vger.kernel.org \
--cc=rientjes@google.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox