From: Borislav Petkov <bp@amd64.org>
To: Ingo Molnar <mingo@elte.hu>
Cc: "H. Peter Anvin" <hpa@zytor.com>,
Thomas Gleixner <tglx@linutronix.de>,
FUJITA Tomonori <fujita.tomonori@lab.ntt.co.jp>,
x86 <x86@kernel.org>, LKML <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] x86, k8 nb: Enable k8_northbridges unconditionally on AMD
Date: Thu, 11 Mar 2010 15:17:31 +0100 [thread overview]
Message-ID: <20100311141731.GD18564@aftab> (raw)
In-Reply-To: <20100311132202.GF11837@elte.hu>
From: Ingo Molnar <mingo@elte.hu>
Date: Thu, Mar 11, 2010 at 02:22:02PM +0100
> > we're getting the following oopsie with current -git. Proposed patch is below:
>
> alas, your patch doesnt always build:
>
> drivers/built-in.o: In function `agp_amd64_probe':
> amd64-agp.c:(.devinit.text+0x81d2): undefined reference to `cache_k8_northbridges'
> amd64-agp.c:(.devinit.text+0x8207): undefined reference to `k8_northbridges'
> amd64-agp.c:(.devinit.text+0x8409): undefined reference to `num_k8_northbridges'
> amd64-agp.c:(.devinit.text+0x8500): undefined reference to `k8_northbridges'
Ah, yep, this patch removes the dependency on K8_NB and it could be that
your config has CONFIG_K8_NB disabled but with CONFIG_AGP_AMD64 enabled.
Can you send me your .config pls?
--
Regards/Gruss,
Boris.
--
Advanced Micro Devices, Inc.
Operating Systems Research Center
next prev parent reply other threads:[~2010-03-11 14:17 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-03-08 17:06 [PATCH] x86, k8 nb: Enable k8_northbridges unconditionally on AMD Borislav Petkov
2010-03-09 1:32 ` FUJITA Tomonori
2010-03-11 13:22 ` Ingo Molnar
2010-03-11 14:17 ` Borislav Petkov [this message]
2010-03-12 14:43 ` [PATCH -v2] " Borislav Petkov
2010-03-13 12:26 ` [tip:x86/urgent] x86, k8 nb: Fix boot crash: enable k8_northbridges unconditionally on AMD systems tip-bot for Borislav Petkov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20100311141731.GD18564@aftab \
--to=bp@amd64.org \
--cc=fujita.tomonori@lab.ntt.co.jp \
--cc=hpa@zytor.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@elte.hu \
--cc=tglx@linutronix.de \
--cc=x86@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox