Re: [PATCH 33/37] sound/soc: use .dev.of_node instead of .node in struct of_device

Grant Likely
2010-04-05T23:48:13Z

Hi Ben, thanks for the comment. Reply below...

On Mon, Apr 5, 2010 at 5:03 PM, Ben Dooks <ben-linux@fluff.org> wrote:
> On Thu, Mar 11, 2010 at 11:06:50AM -0700, Grant Likely wrote:
>> .node is being removed
[...]
>> --- a/sound/soc/fsl/mpc8610_hpcd.c
>> +++ b/sound/soc/fsl/mpc8610_hpcd.c
>> @@ -202,7 +202,7 @@ static struct snd_soc_ops mpc8610_hpcd_ops = {
>>  static int mpc8610_hpcd_probe(struct of_device *ofdev,
>>       const struct of_device_id *match)
>>  {
>> -     struct device_node *np = ofdev->node;
>> +     struct device_node *np = ofdev->dev.of_node;
>>       struct device_node *codec_np = NULL;
>>       struct device_node *guts_np = NULL;
>>       struct device_node *dma_np = NULL;
>
> This looks like one case where an inline function would have been a
> help.

In what regard (how would you like it to look)? The node pointer
location is very unlikely to move again, and I prefer the clarity of
direct dereferencing.

g.