From: Greg KH <greg@kroah.com>
To: Eric Dumazet <eric.dumazet@gmail.com>,
Kay Sievers <kay.sievers@vrfy.org>
Cc: linux-kernel <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] kobject: Fix kobject_set_name_vargs()
Date: Thu, 11 Mar 2010 20:15:18 -0800 [thread overview]
Message-ID: <20100312041518.GA31394@kroah.com> (raw)
In-Reply-To: <1268340652.2845.10.camel@edumazet-laptop>
On Thu, Mar 11, 2010 at 09:50:52PM +0100, Eric Dumazet wrote:
> In case of kvasprintf() failure, we can leak old kobject name.
>
> Signed-off-by: Eric Dumazet <eric.dumazet@gmail.com>
> ---
> diff --git a/lib/kobject.c b/lib/kobject.c
> index 8115eb1..1247c57 100644
> --- a/lib/kobject.c
> +++ b/lib/kobject.c
> @@ -222,8 +222,10 @@ int kobject_set_name_vargs(struct kobject *kobj, const char *fmt,
> return 0;
>
> kobj->name = kvasprintf(GFP_KERNEL, fmt, vargs);
> - if (!kobj->name)
> + if (!kobj->name) {
> + kobj->name = old_name;
> return -ENOMEM;
> + }
Are you sure? I think we've been over this very thing many times in the
past...
Kay, I can't recall the issue here, can you?
thanks,
greg k-h
next prev parent reply other threads:[~2010-03-12 4:16 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-03-11 20:50 [PATCH] kobject: Fix kobject_set_name_vargs() Eric Dumazet
2010-03-12 4:15 ` Greg KH [this message]
2010-03-12 4:39 ` Kay Sievers
2010-03-12 4:46 ` Kay Sievers
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20100312041518.GA31394@kroah.com \
--to=greg@kroah.com \
--cc=eric.dumazet@gmail.com \
--cc=kay.sievers@vrfy.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox