public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: Arnaldo Carvalho de Melo <acme@infradead.org>
To: Avi Kivity <avi@redhat.com>
Cc: "Ingo Molnar" <mingo@elte.hu>,
	linux-kernel@vger.kernel.org,
	"Frédéric Weisbecker" <fweisbec@gmail.com>,
	"Mike Galbraith" <efault@gmx.de>,
	"Peter Zijlstra" <a.p.zijlstra@chello.nl>,
	"Paul Mackerras" <paulus@samba.org>
Subject: Re: [PATCH v2 5/5] perf report: Initial TUI using newt
Date: Fri, 12 Mar 2010 10:27:18 -0300	[thread overview]
Message-ID: <20100312132718.GO14180@ghostprotocols.net> (raw)
In-Reply-To: <4B9A0F78.7020201@redhat.com>

Em Fri, Mar 12, 2010 at 11:55:04AM +0200, Avi Kivity escreveu:
> On 03/12/2010 11:45 AM, Ingo Molnar wrote:
>>
>>   - When i hit enter on a symbol to annotate it, but the annotation fails, the TUI
>>     just does nothing currently. Instead it should print something informative
>>     (and eye-catching) into a status line at the top or the bottom of the
>>     screen, possibly printed in red characters or so. Not a separate window as that
>>     needs extra key-hits to get rid of - just a sufficiently visible status
>>     line would be perfect. There can be a few reasons why some functions can be
>>     annotated while others cannot be.
>
> Alternatively, mark it as unannotatable in the first place (e.g. an  
> annotatable symbol is a hyperlink, an unannotatable one is not).  But  
> perhaps that's too computationally expensive.

I'll come up with some way to do that, changing the color or adding
markings to highlight the top functions, like the stdio one does with
red for te top functions, etc is needed.

- Arnaldo

  reply	other threads:[~2010-03-12 13:27 UTC|newest]

Thread overview: 14+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2010-03-11 23:12 [PATCH v2 1/5] perf symbols: Bump plt synthesizing warning debug level Arnaldo Carvalho de Melo
2010-03-11 23:12 ` [PATCH v2 2/5] perf top: Export get_window_dimensions Arnaldo Carvalho de Melo
2010-03-11 23:12 ` [PATCH v2 3/5] perf tools: Use eprintf for pr_{err,warning,info} too Arnaldo Carvalho de Melo
2010-03-11 23:12 ` [PATCH v2 4/5] perf tools: Add missing bytes printed in hist_entry__fprintf Arnaldo Carvalho de Melo
2010-03-11 23:12 ` [PATCH v2 5/5] perf report: Initial TUI using newt Arnaldo Carvalho de Melo
2010-03-11 23:29   ` Arnaldo Carvalho de Melo
2010-03-12  5:43     ` Frederic Weisbecker
2010-03-12  8:21     ` Avi Kivity
2010-03-12  6:48   ` Mike Galbraith
     [not found]     ` <1268377317.24910.1.camel@marge.simson.net>
2010-03-12 13:56       ` Arnaldo Carvalho de Melo
2010-03-12  9:45   ` Ingo Molnar
2010-03-12  9:55     ` Avi Kivity
2010-03-12 13:27       ` Arnaldo Carvalho de Melo [this message]
2010-03-12 13:25     ` Arnaldo Carvalho de Melo

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20100312132718.GO14180@ghostprotocols.net \
    --to=acme@infradead.org \
    --cc=a.p.zijlstra@chello.nl \
    --cc=avi@redhat.com \
    --cc=efault@gmx.de \
    --cc=fweisbec@gmail.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mingo@elte.hu \
    --cc=paulus@samba.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox