From: Dan Carpenter <error27@gmail.com>
To: Lars Lindley <lindley@coyote.org>
Cc: gregkh@suse.de, greg@kroah.com, penberg@cs.helsinki.fi,
pavel@ucw.cz, diegoliz@gmail.com, devel@driverdev.osuosl.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] staging: winbond: mds.c whitspace, indentation etc.
Date: Sat, 13 Mar 2010 17:40:21 +0300 [thread overview]
Message-ID: <20100313144021.GA19207@bicker> (raw)
In-Reply-To: <1268489199-5356-1-git-send-email-lindley@coyote.org>
First of all, thanks for the patch. I verified that the compiled version
was the same before and after. It cleans up the code a lot.
> + } else { /*DSSS*/
> + /*CTS duration
> + *2 SIFS + DATA transmit time + 1 ACK
> + * Rate : ?? Mega bps
> + *ACK frame length = 14 bytes
> + */
There are a couple places like this. Could you put spaces between the
'*' and the first character? In fact those two comments could be combined
probably.
Once you fix that, check everything again and resend. Looks good.
regards,
dan carpenter
next prev parent reply other threads:[~2010-03-13 14:42 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-03-13 14:06 [PATCH] staging: winbond: mds.c whitspace, indentation etc Lars Lindley
2010-03-13 14:40 ` Dan Carpenter [this message]
-- strict thread matches above, loose matches on Subject: below --
2010-03-15 16:36 Lars Lindley
2010-03-15 16:50 ` Dan Carpenter
2010-03-15 16:52 ` Pekka Enberg
2010-03-15 17:21 ` Lars Lindley
2010-03-15 18:14 ` Pekka Enberg
2010-03-15 19:35 ` Greg KH
2010-03-15 20:12 ` Stefan Richter
2010-04-28 22:47 ` Greg KH
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20100313144021.GA19207@bicker \
--to=error27@gmail.com \
--cc=devel@driverdev.osuosl.org \
--cc=diegoliz@gmail.com \
--cc=greg@kroah.com \
--cc=gregkh@suse.de \
--cc=lindley@coyote.org \
--cc=linux-kernel@vger.kernel.org \
--cc=pavel@ucw.cz \
--cc=penberg@cs.helsinki.fi \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox