From: Cyrill Gorcunov <gorcunov@gmail.com>
To: Ingo Molnar <mingo@elte.hu>
Cc: Lin Ming <ming.m.lin@intel.com>,
Peter Zijlstra <peterz@infradead.org>,
LKML <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] x86,perf: Unmask LVTPC only if we have APIC supported
Date: Sat, 13 Mar 2010 18:03:05 +0300 [thread overview]
Message-ID: <20100313150305.GE18623@lenovo> (raw)
In-Reply-To: <20100313135022.GA4267@elte.hu>
On Sat, Mar 13, 2010 at 02:50:22PM +0100, Ingo Molnar wrote:
...
> > All-in-once: unresolved external symbol here, which could be fixed either by
> > introducing dummy symbol, or conditional compilation. I think the second is
> > preferred if the issue is just one line code.
> >
> > Or you mean something different and I took a wrong mind-path?
>
> Well it's not just one line of code as (like you mentioned) perf_event.c is
> affected as well.
>
> Introducing a dummy (NOP) placeholder method is what we are doing in all the
> other cases (such as spin_lock()), we dont pollute the kernel with #ifdefs.
>
> Ingo
>
ok, Ingo, this will consume some time. Could you pick up the original patch
just for now (so that testing builds will not fail), I'll back to this task
tomorrow or at Monday. OK?
-- Cyrill
next prev parent reply other threads:[~2010-03-13 15:03 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-03-13 8:11 [PATCH] x86,perf: Unmask LVTPC only if we have APIC supported Cyrill Gorcunov
2010-03-13 12:24 ` Ingo Molnar
2010-03-13 12:32 ` Cyrill Gorcunov
2010-03-13 12:40 ` Ingo Molnar
2010-03-13 12:42 ` Ingo Molnar
2010-03-13 13:42 ` Cyrill Gorcunov
2010-03-13 13:50 ` Ingo Molnar
2010-03-13 14:08 ` Cyrill Gorcunov
2010-03-13 15:03 ` Cyrill Gorcunov [this message]
2010-03-13 16:21 ` [tip:perf/core] x86, perf: " tip-bot for Cyrill Gorcunov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20100313150305.GE18623@lenovo \
--to=gorcunov@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=ming.m.lin@intel.com \
--cc=mingo@elte.hu \
--cc=peterz@infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox