From: David Miller <davem@davemloft.net>
To: eric.dumazet@gmail.com
Cc: oleg@redhat.com, mingo@elte.hu, sergey.senozhatsky@gmail.com,
romieu@fr.zoreil.com, a.p.zijlstra@chello.nl,
netdev@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: inconsistent lock state
Date: Mon, 15 Mar 2010 14:09:51 -0700 (PDT) [thread overview]
Message-ID: <20100315.140951.149828242.davem@davemloft.net> (raw)
In-Reply-To: <1268686865.2824.4.camel@edumazet-laptop>
From: Eric Dumazet <eric.dumazet@gmail.com>
Date: Mon, 15 Mar 2010 22:01:05 +0100
> Also, this driver schedules a reset in case a fifo error is reported in
> rtl8169_rx_interrupt()
>
> if (status & RxFOVF) {
> rtl8169_schedule_work(dev, rtl8169_reset_task);
> dev->stats.rx_fifo_errors++;
> }
>
>
> This seems very strange too : In case of a RX spike, we reset card ?
It's possible that this has been found to hang the card.
If so, it should be documented because otherwise yes we
should not be doing this.
next prev parent reply other threads:[~2010-03-15 21:09 UTC|newest]
Thread overview: 24+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <20100307192305.GA598@elte.hu>
2010-03-08 12:51 ` inconsistent lock state Oleg Nesterov
2010-03-15 21:01 ` Eric Dumazet
2010-03-15 21:09 ` David Miller [this message]
2010-03-16 0:33 ` [PATCH] r8169: Fix rtl8169_rx_interrupt() Eric Dumazet
2010-03-16 6:50 ` Sergey Senozhatsky
2010-03-16 7:12 ` Eric Dumazet
2010-03-16 14:50 ` Sergey Senozhatsky
2010-03-16 15:00 ` Sergey Senozhatsky
2010-03-16 15:05 ` Eric Dumazet
2010-03-16 15:10 ` Sergey Senozhatsky
2010-03-16 15:20 ` Eric Dumazet
2010-03-16 18:26 ` Sergey Senozhatsky
2010-03-16 18:48 ` Eric Dumazet
2010-03-16 19:02 ` Sergey Senozhatsky
2010-03-17 7:25 ` Sergey Senozhatsky
2010-06-15 11:24 inconsistent lock state Sergey Senozhatsky
2010-06-18 20:30 ` Andrew Morton
2010-06-19 8:33 ` Sergey Senozhatsky
2010-06-19 13:05 ` Dominik Brodowski
2010-06-21 6:54 ` Peter Zijlstra
2010-06-22 8:59 ` Eric Dumazet
2010-06-22 17:17 ` Paul E. McKenney
-- strict thread matches above, loose matches on Subject: below --
2010-06-01 10:13 Pedro M. López
2010-03-07 10:21 Sergey Senozhatsky
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20100315.140951.149828242.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=a.p.zijlstra@chello.nl \
--cc=eric.dumazet@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@elte.hu \
--cc=netdev@vger.kernel.org \
--cc=oleg@redhat.com \
--cc=romieu@fr.zoreil.com \
--cc=sergey.senozhatsky@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).