The Linux Kernel Mailing List
 help / color / mirror / Atom feed
From: Pavel Machek <pavel@ucw.cz>
To: Chihau Chau <chihau@gmail.com>, Greg KH <greg@kroah.com>
Cc: gregkh@suse.de, devel@driverdev.osuosl.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] Staging: dream: smd: smd_private: fix code style issues
Date: Mon, 15 Mar 2010 06:32:34 +0100	[thread overview]
Message-ID: <20100315053233.GA11552@elf.ucw.cz> (raw)
In-Reply-To: <1268623742-10872-1-git-send-email-chihau@gmail.com>

On Mon 2010-03-15 00:29:02, Chihau Chau wrote:
> From: Chihau Chau <chihau@gmail.com>
> 
> This put open braces '{' following structs on the same line.
> 
> Signed-off-by: Chihau Chau <chihau@gmail.com>

ACK.

> ---
>  drivers/staging/dream/smd/smd_private.h |   21 +++++++--------------
>  1 files changed, 7 insertions(+), 14 deletions(-)
> 
> diff --git a/drivers/staging/dream/smd/smd_private.h b/drivers/staging/dream/smd/smd_private.h
> index c0eb3de..1b2e1c8 100644
> --- a/drivers/staging/dream/smd/smd_private.h
> +++ b/drivers/staging/dream/smd/smd_private.h
> @@ -16,24 +16,21 @@
>  #ifndef _ARCH_ARM_MACH_MSM_MSM_SMD_PRIVATE_H_
>  #define _ARCH_ARM_MACH_MSM_MSM_SMD_PRIVATE_H_
>  
> -struct smem_heap_info
> -{
> +struct smem_heap_info {
>  	unsigned initialized;
>  	unsigned free_offset;
>  	unsigned heap_remaining;
>  	unsigned reserved;
>  };
>  
> -struct smem_heap_entry
> -{
> +struct smem_heap_entry {
>  	unsigned allocated;
>  	unsigned offset;
>  	unsigned size;
>  	unsigned reserved;
>  };
>  
> -struct smem_proc_comm
> -{
> +struct smem_proc_comm {
>  	unsigned command;
>  	unsigned status;
>  	unsigned data1;
> @@ -49,22 +46,19 @@ struct smem_proc_comm
>  #define VERSION_APPS      8
>  #define VERSION_MODEM     9
>  
> -struct smem_shared
> -{
> +struct smem_shared {
>  	struct smem_proc_comm proc_comm[4];
>  	unsigned version[32];
>  	struct smem_heap_info heap_info;
>  	struct smem_heap_entry heap_toc[128];
>  };
>  
> -struct smsm_shared
> -{
> +struct smsm_shared {
>  	unsigned host;
>  	unsigned state;
>  };
>  
> -struct smsm_interrupt_info
> -{
> +struct smsm_interrupt_info {
>  	uint32_t aArm_en_mask;
>  	uint32_t aArm_interrupts_pending;
>  	uint32_t aArm_wakeup_reason;
> @@ -108,8 +102,7 @@ void smsm_print_sleep_info(void);
>  
>  #define SMEM_NUM_SMD_CHANNELS        64
>  
> -typedef enum
> -{
> +typedef enum {
>  	/* fixed items */
>  	SMEM_PROC_COMM = 0,
>  	SMEM_HEAP_INFO,

-- 
(english) http://www.livejournal.com/~pavelmachek
(cesky, pictures) http://atrey.karlin.mff.cuni.cz/~pavel/picture/horses/blog.html

  reply	other threads:[~2010-03-15  5:32 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2010-03-15  3:29 [PATCH] Staging: dream: smd: smd_private: fix code style issues Chihau Chau
2010-03-15  5:32 ` Pavel Machek [this message]
2010-04-10 18:09   ` Chihau Chau
2010-04-28 18:42     ` Greg KH

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20100315053233.GA11552@elf.ucw.cz \
    --to=pavel@ucw.cz \
    --cc=chihau@gmail.com \
    --cc=devel@driverdev.osuosl.org \
    --cc=greg@kroah.com \
    --cc=gregkh@suse.de \
    --cc=linux-kernel@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox