* [PATCH] c2port: fix device_create() return value check
@ 2010-03-11 16:20 Jani Nikula
2010-03-15 22:13 ` Andrew Morton
0 siblings, 1 reply; 2+ messages in thread
From: Jani Nikula @ 2010-03-11 16:20 UTC (permalink / raw)
To: linux-kernel; +Cc: giometti, vegard.nossum, akpm, ext-jani.1.nikula
From: Jani Nikula <ext-jani.1.nikula@nokia.com>
Use IS_ERR() instead of comparing to NULL.
Signed-off-by: Jani Nikula <ext-jani.1.nikula@nokia.com>
---
NOTE: I'm afraid I'm unable to test this; please consider this more a
bug report than a complete patch.
---
drivers/misc/c2port/core.c | 2 +-
1 files changed, 1 insertions(+), 1 deletions(-)
diff --git a/drivers/misc/c2port/core.c b/drivers/misc/c2port/core.c
index b5346b4..3276216 100644
--- a/drivers/misc/c2port/core.c
+++ b/drivers/misc/c2port/core.c
@@ -912,7 +912,7 @@ struct c2port_device *c2port_device_register(char *name,
c2dev->dev = device_create(c2port_class, NULL, 0, c2dev,
"c2port%d", id);
- if (unlikely(!c2dev->dev)) {
+ if (unlikely(IS_ERR(c2dev->dev))) {
ret = -ENOMEM;
goto error_device_create;
}
--
1.6.5.2
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH] c2port: fix device_create() return value check
2010-03-11 16:20 [PATCH] c2port: fix device_create() return value check Jani Nikula
@ 2010-03-15 22:13 ` Andrew Morton
0 siblings, 0 replies; 2+ messages in thread
From: Andrew Morton @ 2010-03-15 22:13 UTC (permalink / raw)
To: Jani Nikula; +Cc: linux-kernel, giometti, vegard.nossum
On Thu, 11 Mar 2010 18:20:52 +0200
Jani Nikula <ext-jani.1.nikula@nokia.com> wrote:
> From: Jani Nikula <ext-jani.1.nikula@nokia.com>
>
> Use IS_ERR() instead of comparing to NULL.
>
> Signed-off-by: Jani Nikula <ext-jani.1.nikula@nokia.com>
>
> ---
>
> NOTE: I'm afraid I'm unable to test this; please consider this more a
> bug report than a complete patch.
> ---
> drivers/misc/c2port/core.c | 2 +-
> 1 files changed, 1 insertions(+), 1 deletions(-)
>
> diff --git a/drivers/misc/c2port/core.c b/drivers/misc/c2port/core.c
> index b5346b4..3276216 100644
> --- a/drivers/misc/c2port/core.c
> +++ b/drivers/misc/c2port/core.c
> @@ -912,7 +912,7 @@ struct c2port_device *c2port_device_register(char *name,
>
> c2dev->dev = device_create(c2port_class, NULL, 0, c2dev,
> "c2port%d", id);
> - if (unlikely(!c2dev->dev)) {
> + if (unlikely(IS_ERR(c2dev->dev))) {
> ret = -ENOMEM;
> goto error_device_create;
> }
It looks right to me. Let's finish the job:
--- a/drivers/misc/c2port/core.c~c2port-fix-device_create-return-value-check-fix
+++ a/drivers/misc/c2port/core.c
@@ -913,7 +913,7 @@ struct c2port_device *c2port_device_regi
c2dev->dev = device_create(c2port_class, NULL, 0, c2dev,
"c2port%d", id);
if (unlikely(IS_ERR(c2dev->dev))) {
- ret = -ENOMEM;
+ ret = PTR_ERR(c2dev->dev);
goto error_device_create;
}
dev_set_drvdata(c2dev->dev, c2dev);
_
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2010-03-15 22:13 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2010-03-11 16:20 [PATCH] c2port: fix device_create() return value check Jani Nikula
2010-03-15 22:13 ` Andrew Morton
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox