From: Ralf Baechle <ralf@linux-mips.org>
To: Wolfram Sang <w.sang@pengutronix.de>
Cc: Dmitry Torokhov <dmitry.torokhov@gmail.com>,
kernel-janitors@vger.kernel.org,
"Eric W. Biederman" <ebiederm@xmission.com>,
linux-mips@linux-mips.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH 1/3] arch/mips/txx9/generic: init dynamic bin_attribute structures
Date: Mon, 15 Mar 2010 18:49:05 +0100 [thread overview]
Message-ID: <20100315174905.GC20055@linux-mips.org> (raw)
In-Reply-To: <20100313022855.GD4034@pengutronix.de>
On Sat, Mar 13, 2010 at 03:28:55AM +0100, Wolfram Sang wrote:
> > Regarding all 3 - it looks like these dynamically alocated attributes
> > could be converted to statically allocated ones. I'd recommend doing
> > that instead (in fact, I posted patch for the firmware_class couple days
> > ago).
>
> I agree for the firmware-patch. Regarding the MIPS one, 'size' might differ and
> 'private' will differ per instance. Regarding the RTC driver, 'size' might also
> differ. I don't know if somebody really wants two RTCs or the SRAM for MIPS can
> be instantiated more than once. Unless somebody with actual hardware jumps in,
> I'd say better safe than sorry.
On the txx9 platform you've posted the patch for additional RTCs or SRAMs
would not normally be expected. On other platforms such as IP27 there
would be one per node that is potencially very many.
Ralf
next prev parent reply other threads:[~2010-03-15 17:49 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <1268377431-11671-1-git-send-email-w.sang@pengutronix.de>
2010-03-12 7:03 ` [PATCH 1/3] arch/mips/txx9/generic: init dynamic bin_attribute structures Wolfram Sang
2010-03-12 18:34 ` Dmitry Torokhov
2010-03-13 2:28 ` Wolfram Sang
2010-03-13 8:33 ` Dmitry Torokhov
2010-03-15 17:49 ` Ralf Baechle [this message]
2010-03-12 7:03 ` [PATCH 2/3] drivers/base: " Wolfram Sang
2010-03-13 2:11 ` Wolfram Sang
2010-03-12 7:03 ` [PATCH 3/3] drivers/rtc: " Wolfram Sang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20100315174905.GC20055@linux-mips.org \
--to=ralf@linux-mips.org \
--cc=dmitry.torokhov@gmail.com \
--cc=ebiederm@xmission.com \
--cc=kernel-janitors@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mips@linux-mips.org \
--cc=w.sang@pengutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox