From: Ingo Molnar <mingo@elte.hu>
To: Yinghai Lu <yinghai@kernel.org>
Cc: Suresh Siddha <suresh.b.siddha@intel.com>,
"H. Peter Anvin" <hpa@zytor.com>,
Thomas Gleixner <tglx@linutronix.de>,
LKML <linux-kernel@vger.kernel.org>,
"Eric W. Biederman" <ebiederm@xmission.com>
Subject: Re: [patch] x86: handle legacy PIC interrupts on all the cpu's
Date: Tue, 16 Mar 2010 06:57:14 +0100 [thread overview]
Message-ID: <20100316055714.GA20758@elte.hu> (raw)
In-Reply-To: <20100316053717.GA10765@elte.hu>
* Ingo Molnar <mingo@elte.hu> wrote:
>
> * Yinghai Lu <yinghai@kernel.org> wrote:
>
> > On 03/15/2010 03:56 PM, Suresh Siddha wrote:
> > > On Mon, 2010-03-15 at 14:51 -0700, Yinghai Lu wrote:
> > >>> + for (irq = 0; irq < legacy_pic->nr_legacy_irqs; irq++)
> > >>> + if (!IO_APIC_IRQ(irq))
> > >>> + per_cpu(vector_irq, cpu)[IRQ0_VECTOR + irq] = irq;
> > >>
> > >> seems those three lines are not needed...
> > >
> > > Those are needed for !CONFIG_X86_IO_APIC case.
> > >
> > then we can have
> >
> > +#ifndef CONFIG_X86_IO_APIC
> > + for (irq = 0; irq < legacy_pic->nr_legacy_irqs; irq++)
> > + per_cpu(vector_irq, cpu)[IRQ0_VECTOR + irq] = irq;
> > +#endif
> >
> > then we don't punish most setup with ioapic controller.
>
> Ok - i've simplified the code with the above and have added your Acked-by - is
> that is fine by you?
btw., the patch fixes the regression on the testbox - thanks Suresh!
Ingo
next prev parent reply other threads:[~2010-03-16 5:57 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-03-15 22:33 [patch] x86: handle legacy PIC interrupts on all the cpu's Suresh Siddha
2010-03-15 21:51 ` Yinghai Lu
2010-03-15 22:56 ` Suresh Siddha
2010-03-15 22:15 ` Yinghai Lu
2010-03-16 5:37 ` Ingo Molnar
2010-03-16 5:57 ` Ingo Molnar [this message]
2010-03-16 6:54 ` Suresh Siddha
2010-03-16 6:35 ` Yinghai Lu
2010-03-16 7:29 ` Ingo Molnar
2010-03-16 6:00 ` [tip:x86/urgent] x86: Handle " tip-bot for Suresh Siddha
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20100316055714.GA20758@elte.hu \
--to=mingo@elte.hu \
--cc=ebiederm@xmission.com \
--cc=hpa@zytor.com \
--cc=linux-kernel@vger.kernel.org \
--cc=suresh.b.siddha@intel.com \
--cc=tglx@linutronix.de \
--cc=yinghai@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox