* [PATCH] Remove GENHD_FL_DRIVERFS
@ 2010-03-16 3:43 NeilBrown
2010-03-16 7:55 ` Jens Axboe
0 siblings, 1 reply; 2+ messages in thread
From: NeilBrown @ 2010-03-16 3:43 UTC (permalink / raw)
To: Jens Axboe; +Cc: linux-kernel
This flag is not used, so best discarded.
Signed-off-by: NeilBrown <neilb@suse.de>
--
Hi Jens,
I came across this recently - these are the only two occurances
of "GENHD_FL_DRIVERFS" in the kernel, so it cannot be needed.
NeilBrown
diff --git a/drivers/scsi/sd.c b/drivers/scsi/sd.c
index 83881df..a82ab3e 100644
--- a/drivers/scsi/sd.c
+++ b/drivers/scsi/sd.c
@@ -2185,7 +2185,7 @@ static void sd_probe_async(void *data, async_cookie_t cookie)
blk_queue_prep_rq(sdp->request_queue, sd_prep_fn);
gd->driverfs_dev = &sdp->sdev_gendev;
- gd->flags = GENHD_FL_EXT_DEVT | GENHD_FL_DRIVERFS;
+ gd->flags = GENHD_FL_EXT_DEVT;
if (sdp->removable)
gd->flags |= GENHD_FL_REMOVABLE;
diff --git a/include/linux/genhd.h b/include/linux/genhd.h
index 56b5051..5f2f4c4 100644
--- a/include/linux/genhd.h
+++ b/include/linux/genhd.h
@@ -109,7 +109,7 @@ struct hd_struct {
};
#define GENHD_FL_REMOVABLE 1
-#define GENHD_FL_DRIVERFS 2
+/* 2 is unused */
#define GENHD_FL_MEDIA_CHANGE_NOTIFY 4
#define GENHD_FL_CD 8
#define GENHD_FL_UP 16
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH] Remove GENHD_FL_DRIVERFS
2010-03-16 3:43 [PATCH] Remove GENHD_FL_DRIVERFS NeilBrown
@ 2010-03-16 7:55 ` Jens Axboe
0 siblings, 0 replies; 2+ messages in thread
From: Jens Axboe @ 2010-03-16 7:55 UTC (permalink / raw)
To: NeilBrown; +Cc: linux-kernel
On Tue, Mar 16 2010, NeilBrown wrote:
>
>
> This flag is not used, so best discarded.
Yep that looks pretty dead, thanks Neil, queued up.
--
Jens Axboe
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2010-03-16 7:55 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2010-03-16 3:43 [PATCH] Remove GENHD_FL_DRIVERFS NeilBrown
2010-03-16 7:55 ` Jens Axboe
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox