public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
* usbtouchscreen: support bigger iNexio touchscreens
@ 2010-03-16 13:23 Ondrej Zary
  2010-03-16 13:26 ` Jiri Kosina
  0 siblings, 1 reply; 2+ messages in thread
From: Ondrej Zary @ 2010-03-16 13:23 UTC (permalink / raw)
  To: Oliver Neukum; +Cc: linux-usb, daniel.ritz, linux-kernel

Bigger Nexio touchscreens not only send more data but also the header values
are modified somehow. Fix the header somehow (it's a guesswork but it works
at least on one 46" touchscreen with 2.00SMS firmware) and also increase
rept_size.

Signed-off-by: Ondrej Zary <linux@rainbow-software.org>

--- linux-2.6.34-rc1-orig/drivers/input/touchscreen/usbtouchscreen.c	2010-03-16 13:34:51.000000000 +0100
+++ linux-2.6.34-rc1/drivers/input/touchscreen/usbtouchscreen.c	2010-03-16 13:46:15.000000000 +0100
@@ -858,6 +858,11 @@
 	if ((pkt[0] & 0xe0) != 0xe0)
 		return 0;
 
+	if (be16_to_cpu(packet->data_len) > 0xff)
+		packet->data_len = cpu_to_be16(be16_to_cpu(packet->data_len) - 0x100);
+	if (be16_to_cpu(packet->x_len) > 0xff)
+		packet->x_len = cpu_to_be16(be16_to_cpu(packet->x_len) - 0x80);
+
 	/* send ACK */
 	ret = usb_submit_urb(priv->ack, GFP_ATOMIC);
 
@@ -1113,7 +1118,7 @@
 
 #ifdef CONFIG_TOUCHSCREEN_USB_NEXIO
 	[DEVTYPE_NEXIO] = {
-		.rept_size	= 128,
+		.rept_size	= 1024,
 		.irq_always	= true,
 		.read_data	= nexio_read_data,
 		.init		= nexio_init,


-- 
Ondrej Zary

^ permalink raw reply	[flat|nested] 2+ messages in thread

* Re: usbtouchscreen: support bigger iNexio touchscreens
  2010-03-16 13:23 usbtouchscreen: support bigger iNexio touchscreens Ondrej Zary
@ 2010-03-16 13:26 ` Jiri Kosina
  0 siblings, 0 replies; 2+ messages in thread
From: Jiri Kosina @ 2010-03-16 13:26 UTC (permalink / raw)
  To: Ondrej Zary
  Cc: Oliver Neukum, linux-usb, daniel.ritz, linux-kernel,
	Dmitry Torokhov, linux-input


[ adding some more relevant CCs ]

On Tue, 16 Mar 2010, Ondrej Zary wrote:

> Bigger Nexio touchscreens not only send more data but also the header values
> are modified somehow. Fix the header somehow (it's a guesswork but it works
> at least on one 46" touchscreen with 2.00SMS firmware) and also increase
> rept_size.
> 
> Signed-off-by: Ondrej Zary <linux@rainbow-software.org>
> 
> --- linux-2.6.34-rc1-orig/drivers/input/touchscreen/usbtouchscreen.c	2010-03-16 13:34:51.000000000 +0100
> +++ linux-2.6.34-rc1/drivers/input/touchscreen/usbtouchscreen.c	2010-03-16 13:46:15.000000000 +0100
> @@ -858,6 +858,11 @@
>  	if ((pkt[0] & 0xe0) != 0xe0)
>  		return 0;
>  
> +	if (be16_to_cpu(packet->data_len) > 0xff)
> +		packet->data_len = cpu_to_be16(be16_to_cpu(packet->data_len) - 0x100);
> +	if (be16_to_cpu(packet->x_len) > 0xff)
> +		packet->x_len = cpu_to_be16(be16_to_cpu(packet->x_len) - 0x80);
> +
>  	/* send ACK */
>  	ret = usb_submit_urb(priv->ack, GFP_ATOMIC);
>  
> @@ -1113,7 +1118,7 @@
>  
>  #ifdef CONFIG_TOUCHSCREEN_USB_NEXIO
>  	[DEVTYPE_NEXIO] = {
> -		.rept_size	= 128,
> +		.rept_size	= 1024,
>  		.irq_always	= true,
>  		.read_data	= nexio_read_data,
>  		.init		= nexio_init,
> 
> 
> 

-- 
Jiri Kosina
SUSE Labs, Novell Inc.


^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2010-03-16 13:26 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2010-03-16 13:23 usbtouchscreen: support bigger iNexio touchscreens Ondrej Zary
2010-03-16 13:26 ` Jiri Kosina

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox