From: Ingo Molnar <mingo@elte.hu>
To: Hitoshi Mitake <mitake@dcl.info.waseda.ac.jp>
Cc: Frederic Weisbecker <fweisbec@gmail.com>,
linux-kernel@vger.kernel.org, h.mitake@gmail.com,
Peter Zijlstra <a.p.zijlstra@chello.nl>,
Paul Mackerras <paulus@samba.org>,
Arnaldo Carvalho de Melo <acme@redhat.com>,
Jens Axboe <jens.axboe@oracle.com>,
Jason Baron <jbaron@redhat.com>
Subject: Re: [PATCH RFC 00/11] lock monitor: Separate features related to lock
Date: Wed, 17 Mar 2010 10:50:38 +0100 [thread overview]
Message-ID: <20100317095038.GC17146@elte.hu> (raw)
In-Reply-To: <4BA085DE.40604@dcl.info.waseda.ac.jp>
* Hitoshi Mitake <mitake@dcl.info.waseda.ac.jp> wrote:
> On 03/17/10 10:47, Frederic Weisbecker wrote:
> > On Sun, Mar 14, 2010 at 07:38:37PM +0900, Hitoshi Mitake wrote:
> >> I implemented it on the branch perf/inject of Frederic's
> random-tracing tree.
> >> Because the branch is hottest place of lock and tracing :)
> >
> >
> > Ouch! You shouldn't do this. The patches inside were
> > trials submitted for review and the resulting discussion
> > concluded that the injection must be redesigned.
>
> Oh, sorry...
> And I'd like to look at redesigning way of inject.
>
> >
> > More generally I don't recommend you to base your patches
> > on my tree. I use it as a buffer when I send patches
> > for review or for pull requests.
> >
> > The branches inside can be randomly rebased (unless a
> > branch is waiting to be pulled) and they are pretty async
> > with the -tip tree.
> >
> > The hottest and most sync tree on which you should base your patches
> > for perf is:
> >
> > git://git.kernel.org/pub/scm/linux/kernel/git/tip/linux-2.6-tip.git
> > perf/core
> >
> > With that you have best chances to work on a sane and up-to-date
> > base.
> >
> > Thanks.
> >
> >
>
> I'll work on tip/perf/core from next time :)
You can also use tip:master for convenience - especially for RFC patches. That
way you will have the latest and greatest (and tested) branches combined :)
Ingo
prev parent reply other threads:[~2010-03-17 9:51 UTC|newest]
Thread overview: 42+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-03-14 10:38 [PATCH RFC 00/11] lock monitor: Separate features related to lock Hitoshi Mitake
2010-03-14 10:38 ` [PATCH RFC 01/11] lock monitor: New subsystem for lock event hooking Hitoshi Mitake
2010-03-14 10:38 ` [PATCH RFC 02/11] Adopt lockdep to lock monitor Hitoshi Mitake
2010-03-14 10:38 ` [PATCH RFC 03/11] Adopt spinlock " Hitoshi Mitake
2010-03-14 10:38 ` [PATCH RFC 04/11] Adopt rwlock " Hitoshi Mitake
2010-03-14 10:38 ` [PATCH RFC 05/11] Adopt arch dependent rwsem " Hitoshi Mitake
2010-03-14 10:38 ` [PATCH RFC 06/11] Adopt rwsem of x86 " Hitoshi Mitake
2010-03-14 10:38 ` [PATCH RFC 07/11] Adopt the way of initializing semaphore " Hitoshi Mitake
2010-03-14 10:38 ` [PATCH RFC 08/11] Adopt mutex " Hitoshi Mitake
2010-03-14 10:38 ` [PATCH RFC 09/11] Adopt rcu_read_lock() " Hitoshi Mitake
2010-03-14 10:38 ` [PATCH RFC 10/11] Adopt kernel/sched.c " Hitoshi Mitake
2010-03-14 10:38 ` [PATCH RFC 11/11] Very dirty temporal solution for testing " Hitoshi Mitake
2010-03-14 18:13 ` [PATCH RFC 00/11] lock monitor: Separate features related to lock Peter Zijlstra
2010-03-17 1:32 ` Frederic Weisbecker
2010-03-17 7:30 ` Hitoshi Mitake
2010-03-17 15:39 ` Frederic Weisbecker
2010-03-18 5:49 ` Hitoshi Mitake
2010-03-18 20:30 ` Frederic Weisbecker
2010-03-20 5:51 ` Hitoshi Mitake
2010-03-23 15:45 ` Peter Zijlstra
2010-03-17 9:52 ` Ingo Molnar
2010-03-17 13:59 ` Jason Baron
2010-03-18 5:59 ` Hitoshi Mitake
2010-03-18 21:16 ` Frederic Weisbecker
2010-03-19 1:08 ` Mathieu Desnoyers
2010-03-19 1:23 ` Frederic Weisbecker
2010-03-19 1:36 ` Mathieu Desnoyers
2010-03-19 2:27 ` Frederic Weisbecker
2010-03-19 2:40 ` Mathieu Desnoyers
2010-03-19 3:06 ` Frederic Weisbecker
2010-03-19 12:56 ` Mathieu Desnoyers
2010-03-19 16:00 ` Jason Baron
2010-03-20 4:51 ` Frederic Weisbecker
2010-03-20 4:46 ` Frederic Weisbecker
2010-03-20 5:56 ` Hitoshi Mitake
2010-03-20 8:23 ` Hitoshi Mitake
2010-03-21 9:49 ` Hitoshi Mitake
2010-03-23 15:32 ` Peter Zijlstra
2010-04-04 7:56 ` Hitoshi Mitake
2010-03-17 1:47 ` Frederic Weisbecker
2010-03-17 7:33 ` Hitoshi Mitake
2010-03-17 9:50 ` Ingo Molnar [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20100317095038.GC17146@elte.hu \
--to=mingo@elte.hu \
--cc=a.p.zijlstra@chello.nl \
--cc=acme@redhat.com \
--cc=fweisbec@gmail.com \
--cc=h.mitake@gmail.com \
--cc=jbaron@redhat.com \
--cc=jens.axboe@oracle.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mitake@dcl.info.waseda.ac.jp \
--cc=paulus@samba.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox