From: Ingo Molnar <mingo@elte.hu>
To: T??r??k Edwin <edwintorok@gmail.com>
Cc: "H. Peter Anvin" <hpa@zytor.com>,
Frederic Weisbecker <fweisbec@gmail.com>,
Ingo Molnar <mingo@redhat.com>,
Thomas Gleixner <tglx@linutronix.de>,
Peter Zijlstra <a.p.zijlstra@chello.nl>,
Paul Mackerras <paulus@samba.org>,
x86@kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] perf: x86: fix callgraphs of 32-bit processes on 64-bit kernels V3.
Date: Wed, 17 Mar 2010 10:54:56 +0100 [thread overview]
Message-ID: <20100317095456.GE17146@elte.hu> (raw)
In-Reply-To: <1268815776-29501-1-git-send-email-edwintorok@gmail.com>
* T??r??k Edwin <edwintorok@gmail.com> wrote:
> +#ifdef CONFIG_COMPAT
> + if (test_thread_flag(TIF_IA32)) {
> + perf_callchain_user32(regs, entry);
> + return;
> + }
> +#endif
You can push that test into perf_callchain_user32() and turn it into something
like:
if (perf_callchain_user32(regs, entry))
return;
without the #ifdef here.
Ingo
next prev parent reply other threads:[~2010-03-17 9:55 UTC|newest]
Thread overview: 22+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-03-15 15:34 fix callgraphs of 32-bit processes on 64-bit kernels Török Edwin
2010-03-15 15:34 ` [PATCH] perf: x86: " Török Edwin
2010-03-16 14:49 ` Frederic Weisbecker
2010-03-16 15:02 ` [PATCH] perf: x86: fix callgraphs of 32-bit processes on 64-bit kernels V2 Török Edwin
2010-03-16 17:05 ` Ingo Molnar
2010-03-17 8:48 ` Török Edwin
2010-03-17 8:49 ` [PATCH] perf: x86: fix callgraphs of 32-bit processes on 64-bit kernels V3 Török Edwin
2010-03-17 9:54 ` Ingo Molnar [this message]
2010-03-17 10:07 ` [PATCH] perf: x86: fix callgraphs of 32-bit processes on 64-bit kernels V4 Török Edwin
2010-03-30 23:18 ` Frederic Weisbecker
2010-03-17 9:59 ` [PATCH] perf: x86: fix callgraphs of 32-bit processes on 64-bit kernels V2 Ingo Molnar
2010-03-16 15:04 ` [PATCH] perf: x86: fix callgraphs of 32-bit processes on 64-bit kernels Török Edwin
2010-03-15 16:23 ` Török Edwin
2010-03-16 8:18 ` Török Edwin
2010-03-16 8:47 ` Ingo Molnar
2010-03-16 10:17 ` Török Edwin
2010-03-16 10:23 ` Ingo Molnar
2010-03-16 9:57 ` [PATCH] perf: install into /usr/local by default Török Edwin
2010-03-16 10:10 ` Ingo Molnar
2010-03-16 10:20 ` Avi Kivity
2010-03-16 10:25 ` Ingo Molnar
2010-03-16 10:24 ` Török Edwin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20100317095456.GE17146@elte.hu \
--to=mingo@elte.hu \
--cc=a.p.zijlstra@chello.nl \
--cc=edwintorok@gmail.com \
--cc=fweisbec@gmail.com \
--cc=hpa@zytor.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@redhat.com \
--cc=paulus@samba.org \
--cc=tglx@linutronix.de \
--cc=x86@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox