public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: Oleg Nesterov <oleg@redhat.com>
To: Andrew Morton <akpm@linux-foundation.org>
Cc: Roland McGrath <roland@redhat.com>,
	Veaceslav Falico <vfalico@redhat.com>,
	linux-kernel@vger.kernel.org
Subject: [PATCH 0/4] signal_struct->count must die, initial changes
Date: Wed, 17 Mar 2010 20:28:47 +0100	[thread overview]
Message-ID: <20100317192847.GA2086@redhat.com> (raw)

signal_struct->count in its current form must die.

	- it has no reasons to be atomic_t

	- it looks like a reference counter, but it is not

	- otoh, we really need to make task->signal refcountable,
	  just look at the extremely ugly task_rq_unlock_wait()
	  called from __exit_signals().

	- we should change the lifetime rules for task->signal,
	  it should be pinned to task_struct. We have a lot of
	  code which can be simplified after that.

	- it is not needed! while the code is correct, any usage
	  of this counter is artificial, except fs/proc uses it
	  correctly to show the number of threads.

This series removes the usage of sig->count from exit pathes.

Oleg.


             reply	other threads:[~2010-03-17 19:30 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2010-03-17 19:28 Oleg Nesterov [this message]
2010-03-17 21:50 ` [PATCH 0/4] signal_struct->count must die, initial changes Roland McGrath
2010-03-18 16:49 ` Veaceslav Falico

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20100317192847.GA2086@redhat.com \
    --to=oleg@redhat.com \
    --cc=akpm@linux-foundation.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=roland@redhat.com \
    --cc=vfalico@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox