From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751612Ab0CRJDX (ORCPT ); Thu, 18 Mar 2010 05:03:23 -0400 Received: from [85.183.11.32] ([85.183.11.32]:54150 "EHLO Dublin.logfs.org" rhost-flags-FAIL-FAIL-OK-OK) by vger.kernel.org with ESMTP id S1751171Ab0CRJDV (ORCPT ); Thu, 18 Mar 2010 05:03:21 -0400 Date: Thu, 18 Mar 2010 10:03:08 +0100 From: =?utf-8?Q?J=F6rn?= Engel To: Francois Romieu , Robert Hancock , David Miller , torvalds@linux-foundation.org, linux-kernel@vger.kernel.org, netdev@vger.kernel.org Subject: Re: [Regression] r8169: enable 64-bit DMA by default for PCI Express devices (v2) Message-ID: <20100318090308.GA3697@Dublin.logfs.org> References: <20100315150806.GA15354@Dublin.logfs.org> <20100315151041.GA15667@Dublin.logfs.org> <20100315.115748.13754030.davem@davemloft.net> <51f3faa71003151628g5edc4d7av8916ac76cb337bfe@mail.gmail.com> <20100316083501.GA3489@Dublin.logfs.org> <20100317205206.GA2699@electric-eye.fr.zoreil.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <20100317205206.GA2699@electric-eye.fr.zoreil.com> User-Agent: Mutt/1.5.18 (2008-05-17) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, 17 March 2010 21:52:06 +0100, Francois Romieu wrote: > On Tue, Mar 16, 2010 at 09:35:01AM +0100, J�rn Engel wrote: > [...] > > I just noticed lspci is also unhappy. > > > > With patch in: > > Bikini:~# lspci -vv > lspci > > pcilib: sysfs_read_vpd: read failed: Connection timed out. > > > > With patch reverted: > > Bikini:~# lspci -vv > lspci2 > > Bikini:~# diff -u lspci* > > --- lspci 2010-03-16 09:03:02.000000000 +0100 > > +++ lspci2 2010-03-16 09:09:36.000000000 +0100 > > @@ -246,7 +246,7 @@ > > Vector table: BAR=4 offset=00000000 > > PBA: BAR=4 offset=00000800 > > Capabilities: [cc] Vital Product Data > > - Not readable > > + Unknown small resource type 00, will not decode more. > > Neither looks good. Agreed. > Did lspci output look different with an older kernel ? Yes. The relevant hunk is this one. Different obviously doesn't mean better. :) @@ -223,7 +221,7 @@ Flags: PMEClk- DSI- D1+ D2+ AuxCurrent=375mA PME(D0+,D1+,D2+,D3hot+,D3cold+) Status: D0 NoSoftRst+ PME-Enable- DSel=0 DScale=0 PME- Capabilities: [50] MSI: Enable+ Count=1/1 Maskable- 64bit+ - Address: 00000000fee0300c Data: 4169 + Address: 00000000fee0300c Data: 4179 Capabilities: [70] Express (v2) Endpoint, MSI 01 DevCap: MaxPayload 256 bytes, PhantFunc 0, Latency L0s <512ns, L1 <64us ExtTag- AttnBtn- AttnInd- PwrInd- RBE+ FLReset- And for completeness he is the full diff. The machine was bought on 16 Jun 2009, so this is the oldest kernel I have. If you want any specific kernels tested, please tell me which ones. Bikini:~# uname -a Linux Bikini 2.6.31-rc2 #193 SMP Sun Mar 14 17:00:08 CET 2010 x86_64 GNU/Linux Bikini:~# lspci -vv > lspci3 Bikini:~# diff -u lspci[23] --- lspci2 2010-03-16 09:09:46.000000000 +0100 +++ lspci3 2010-03-18 09:49:21.000000000 +0100 @@ -24,14 +24,12 @@ Status: D0 NoSoftRst- PME-Enable- DSel=0 DScale=0 PME- 00:1c.0 PCI bridge: Intel Corporation 82801G (ICH7 Family) PCI Express Port 1 (rev 01) (prog-if 00 [Normal decode]) - Control: I/O+ Mem+ BusMaster+ SpecCycle- MemWINV- VGASnoop- ParErr- Stepping- SERR+ FastB2B- DisINTx+ + Control: I/O- Mem+ BusMaster+ SpecCycle- MemWINV- VGASnoop- ParErr- Stepping- SERR+ FastB2B- DisINTx+ Status: Cap+ 66MHz- UDF- FastB2B- ParErr- DEVSEL=fast >TAbort- SERR- TAbort- TAbort- Reset- FastB2B- PriDiscTmr- SecDiscTmr- DiscTmrStat- DiscTmrSERREn- Capabilities: [40] Express (v1) Root Port (Slot+), MSI 00 @@ -56,14 +54,14 @@ RootCap: CRSVisible- RootSta: PME ReqID 0000, PMEStatus- PMEPending- Capabilities: [80] MSI: Enable+ Count=1/1 Maskable- 64bit- - Address: fee0300c Data: 4149 + Address: fee0300c Data: 4159 Capabilities: [90] Subsystem: ASRock Incorporation Device 27d0 Capabilities: [a0] Power Management version 2 Flags: PMEClk- DSI- D1- D2- AuxCurrent=0mA PME(D0+,D1-,D2-,D3hot+,D3cold+) Status: D0 NoSoftRst- PME-Enable- DSel=0 DScale=0 PME- Capabilities: [100] Virtual Channel Capabilities: [180] Root Complex Link - Kernel driver in use: pcieport + Kernel driver in use: pcieport-driver 00:1c.1 PCI bridge: Intel Corporation 82801G (ICH7 Family) PCI Express Port 2 (rev 01) (prog-if 00 [Normal decode]) Control: I/O+ Mem+ BusMaster+ SpecCycle- MemWINV- VGASnoop- ParErr- Stepping- SERR+ FastB2B- DisINTx+ @@ -98,14 +96,14 @@ RootCap: CRSVisible- RootSta: PME ReqID 0000, PMEStatus- PMEPending- Capabilities: [80] MSI: Enable+ Count=1/1 Maskable- 64bit- - Address: fee0300c Data: 4151 + Address: fee0300c Data: 4161 Capabilities: [90] Subsystem: ASRock Incorporation Device 27d2 Capabilities: [a0] Power Management version 2 Flags: PMEClk- DSI- D1- D2- AuxCurrent=0mA PME(D0+,D1-,D2-,D3hot+,D3cold+) Status: D0 NoSoftRst- PME-Enable- DSel=0 DScale=0 PME- Capabilities: [100] Virtual Channel Capabilities: [180] Root Complex Link - Kernel driver in use: pcieport + Kernel driver in use: pcieport-driver 00:1d.0 USB Controller: Intel Corporation 82801G (ICH7 Family) USB UHCI Controller #1 (rev 01) (prog-if 00 [UHCI]) Subsystem: ASRock Incorporation Device 27c8 @@ -223,7 +221,7 @@ Flags: PMEClk- DSI- D1+ D2+ AuxCurrent=375mA PME(D0+,D1+,D2+,D3hot+,D3cold+) Status: D0 NoSoftRst+ PME-Enable- DSel=0 DScale=0 PME- Capabilities: [50] MSI: Enable+ Count=1/1 Maskable- 64bit+ - Address: 00000000fee0300c Data: 4169 + Address: 00000000fee0300c Data: 4179 Capabilities: [70] Express (v2) Endpoint, MSI 01 DevCap: MaxPayload 256 bytes, PhantFunc 0, Latency L0s <512ns, L1 <64us ExtTag- AttnBtn- AttnInd- PwrInd- RBE+ FLReset-