Re: [V2 PATCH 00/10] of: Consolidate scattered device node pointers in struct device

Grant Likely
2010-03-23T07:07:09Z

On Tue, Mar 23, 2010 at 12:57 AM, Michael Ellerman
<michael@ellerman.id.au> wrote:
> On Thu, 2010-03-18 at 09:22 -0600, Grant Likely wrote:
>> Currently, each of_device has a copy of the device tree node pointer in both
>> .node, and in .dev.archdata.of_node (microblaze and powerpc) or
>> .dev.archdata.prom_node (sparc).  Also, other architectures will be adding
>> CONFIG_OF support, and they will also need a reference to the device tree
>> node pointer from struct device.
>
> Assuming this is similar to your experimental-devicetree branch, as of
> 96b4b9d7 it causes a few build errors for me:
>
> http://kisskb.ellerman.id.au/kisskb/head/2688/
>
> Broken are 86xx/sbc8641d_defconfig, mpc83xx_defconfig,
> mpc885_ads_defconfig, mpc85xx_defconfig, and pmac32_defconfig.

Hey Michael,

Thanks for the testing. I haven't built through all the defconfigs
yet so this doesn't surprise me too much that I've missed some
drivers. The failure is caused in the last three commits which remove
the old variables. I'll pick through the failing defconfigs, fix and
test them, and refresh my branch.

I'll let you know when the branch is updated.

Cheers,
g.

--
Grant Likely, B.Sc., P.Eng.
Secret Lab Technologies Ltd.