Re: [PATCH 2/2] ia64: ptrace_attach_sync_user_rbs: avoid "task->signal != NULL" checks

Roland McGrath
2010-04-08T01:54:52Z

Acked-by: Roland McGrath <roland@redhat.com>

> Note: this code doesn't need this check and tasklist_lock at all,
> it should be converted to use lock_task_sighand(). And, the code
> under SIGNAL_STOP_STOPPED check looks wrong.

Agreed. It should match that part of ptrace_untrace().

Thanks,
Roland