From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752119Ab0CSLuK (ORCPT ); Fri, 19 Mar 2010 07:50:10 -0400 Received: from mail-bw0-f209.google.com ([209.85.218.209]:56642 "EHLO mail-bw0-f209.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751110Ab0CSLuI (ORCPT ); Fri, 19 Mar 2010 07:50:08 -0400 DomainKey-Signature: a=rsa-sha1; c=nofws; d=gmail.com; s=gamma; h=date:from:to:cc:subject:message-id:mail-followup-to:mime-version :content-type:content-disposition:user-agent; b=epYgaTQZQNqutQkLl4da2xHLcDB2k1BiNygnAu6gZJomnLUXy8dLu+0T1aaelNih2Q ppW+u/s4pRV/Prckt/W1VN0PaVY0i3k3mKaG0Ef1miJNzdMLz4TSSPLZPqoCkUEUA67+ CMnrDD9BLfkOl3hljPF1kFdf7ouGVRa4/JyEw= Date: Fri, 19 Mar 2010 14:49:57 +0300 From: Dan Carpenter To: Mauro Carvalho Chehab Cc: Srinivasa Deevi , linux-media@vger.kernel.org, linux-kernel@vger.kernel.org, kernel-janitors@vger.kernel.org Subject: [patch] cx231xx: card->driver "Conexant cx231xx Audio" too long Message-ID: <20100319114957.GQ5331@bicker> Mail-Followup-To: Dan Carpenter , Mauro Carvalho Chehab , Srinivasa Deevi , linux-media@vger.kernel.org, linux-kernel@vger.kernel.org, kernel-janitors@vger.kernel.org MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline User-Agent: Mutt/1.5.18 (2008-05-17) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org card->driver is 15 characters and a NULL, the original code could cause a buffer overflow. Signed-off-by: Dan Carpenter diff --git a/drivers/media/video/cx231xx/cx231xx-audio.c b/drivers/media/video/cx231xx/cx231xx-audio.c index 7793d60..b3282ae 100644 --- a/drivers/media/video/cx231xx/cx231xx-audio.c +++ b/drivers/media/video/cx231xx/cx231xx-audio.c @@ -495,7 +495,7 @@ static int cx231xx_audio_init(struct cx231xx *dev) pcm->info_flags = 0; pcm->private_data = dev; strcpy(pcm->name, "Conexant cx231xx Capture"); - strcpy(card->driver, "Conexant cx231xx Audio"); + strcpy(card->driver, "Cx231xx Audio"); strcpy(card->shortname, "Cx231xx Audio"); strcpy(card->longname, "Conexant cx231xx Audio");