[PATCH 0/2] blacklist lid status: Sony VGN-BX196VP and Elite Co.

[PATCH 0/2] blacklist lid status: Sony VGN-BX196VP and Elite Co.

[Surbhi Palande]

The following two patches are quirks that blacklist bios which report
incorrect lid status. These are bioses for machines with a 900 GM.
The first one is tested by Ubuntu users and the second one isn't.
Further testing will be appreciated.


Surbhi Palande (2):
  drm/i915: blacklist lid status: Sony VGN-BX196VP
  drm/i915: blacklist lid status: Elite Co. G335

 drivers/gpu/drm/i915/intel_lvds.c |   14 ++++++++++++++
 1 files changed, 14 insertions(+), 0 deletions(-)

[PATCH 1/2] drm/i915: blacklist lid status: Sony VGN-BX196VP

[Surbhi Palande]

BugLink: http://launchpad.net/bug/515246

Sony VGN-BX196VP reports the lid status as closed when it is open. This
leads to a "no connectors reported" error at startup. Blacklisting
it to always return a connected status for the default lvds connector.

Signed-off-by: Surbhi Palande <surbhi.palande@canonical.com>
---
 drivers/gpu/drm/i915/intel_lvds.c |    7 +++++++
 1 files changed, 7 insertions(+), 0 deletions(-)

diff --git a/drivers/gpu/drm/i915/intel_lvds.c b/drivers/gpu/drm/i915/intel_lvds.c
index c2e8a45..afd0ee7 100644
--- a/drivers/gpu/drm/i915/intel_lvds.c
+++ b/drivers/gpu/drm/i915/intel_lvds.c
@@ -643,6 +643,13 @@ static const struct dmi_system_id bad_lid_status[] = {
 			DMI_MATCH(DMI_BOARD_NAME, "M5x0N"),
 		},
 	},
+	{
+		.ident = "Sony VGN-BX196VP",
+		.matches = {
+			DMI_MATCH(DMI_SYS_VENDOR, "Sony Corporation"),
+			DMI_MATCH(DMI_BOARD_NAME, "VGN-BX196VP"),
+		},
+	},
 	{ }
 };
 
-- 
1.6.3.3

[PATCH 2/2] drm/i915: blacklist lid status: Elite Co. G335

[Surbhi Palande]

BugLink: http://launchpad.net/bug/515246

Elite Computers G335 reports the lid status as closed when it is open. This
leads to a "no connectors reported" error at startup. Blacklisting
it to always return a connected status for the default lvds connector.

Signed-off-by: Surbhi Palande <surbhi.palande@canonical.com>
---
 drivers/gpu/drm/i915/intel_lvds.c |    7 +++++++
 1 files changed, 7 insertions(+), 0 deletions(-)

diff --git a/drivers/gpu/drm/i915/intel_lvds.c b/drivers/gpu/drm/i915/intel_lvds.c
index afd0ee7..b75a941 100644
--- a/drivers/gpu/drm/i915/intel_lvds.c
+++ b/drivers/gpu/drm/i915/intel_lvds.c
@@ -650,6 +650,13 @@ static const struct dmi_system_id bad_lid_status[] = {
 			DMI_MATCH(DMI_BOARD_NAME, "VGN-BX196VP"),
 		},
 	},
+	{
+		.ident = "Elitegroup ECS G335",
+		.matches = {
+			DMI_MATCH(DMI_SYS_VENDOR, "Elitegroup Co."),
+			DMI_MATCH(DMI_BOARD_NAME, "ECS G335"),
+		},
+	},
 	{ }
 };
 
-- 
1.6.3.3

Re: ACPI _LID failures

[Jesse Barnes]

On Mon, 15 Mar 2010 21:32:41 +0200
Surbhi Palande <surbhi.palande@canonical.com> wrote:

> The following two patches are quirks that blacklist bios which report
> incorrect lid status. These are bioses for machines with a 900 GM.
> The first one is tested by Ubuntu users and the second one isn't.
> Further testing will be appreciated.
> 
> 
> Surbhi Palande (2):
>   drm/i915: blacklist lid status: Sony VGN-BX196VP
>   drm/i915: blacklist lid status: Elite Co. G335
> 
>  drivers/gpu/drm/i915/intel_lvds.c |   14 ++++++++++++++
>  1 files changed, 14 insertions(+), 0 deletions(-)

Patches look ok to me.  Len was curious about whether some recent ACPI
EC fixes will fix some of our lid detection bugs though.

Len, is there any particular patch or version people should try?

Thanks,
-- 
Jesse Barnes, Intel Open Source Technology Center

Re: ACPI _LID failures

[Eric Anholt]

[-- Attachment #1: Type: text/plain, Size: 1123 bytes --]

On Fri, 19 Mar 2010 12:53:20 -0700, Jesse Barnes <jbarnes@virtuousgeek.org> wrote:
> On Mon, 15 Mar 2010 21:32:41 +0200
> Surbhi Palande <surbhi.palande@canonical.com> wrote:
> 
> > The following two patches are quirks that blacklist bios which report
> > incorrect lid status. These are bioses for machines with a 900 GM.
> > The first one is tested by Ubuntu users and the second one isn't.
> > Further testing will be appreciated.
> > 
> > 
> > Surbhi Palande (2):
> >   drm/i915: blacklist lid status: Sony VGN-BX196VP
> >   drm/i915: blacklist lid status: Elite Co. G335
> > 
> >  drivers/gpu/drm/i915/intel_lvds.c |   14 ++++++++++++++
> >  1 files changed, 14 insertions(+), 0 deletions(-)
> 
> Patches look ok to me.  Len was curious about whether some recent ACPI
> EC fixes will fix some of our lid detection bugs though.
> 
> Len, is there any particular patch or version people should try?

Unless ACPI is going to magically become more reliable at the lid
method, I think we should abandon using it on generations where it
fails.  See other patch I submitted -- anyone care to ack it?

[-- Attachment #2: Type: application/pgp-signature, Size: 197 bytes --]

Re: ACPI _LID failures

[Jesse Barnes]

On Fri, 19 Mar 2010 13:53:10 -0700
Eric Anholt <eric@anholt.net> wrote:

> On Fri, 19 Mar 2010 12:53:20 -0700, Jesse Barnes <jbarnes@virtuousgeek.org> wrote:
> > On Mon, 15 Mar 2010 21:32:41 +0200
> > Surbhi Palande <surbhi.palande@canonical.com> wrote:
> > 
> > > The following two patches are quirks that blacklist bios which report
> > > incorrect lid status. These are bioses for machines with a 900 GM.
> > > The first one is tested by Ubuntu users and the second one isn't.
> > > Further testing will be appreciated.
> > > 
> > > 
> > > Surbhi Palande (2):
> > >   drm/i915: blacklist lid status: Sony VGN-BX196VP
> > >   drm/i915: blacklist lid status: Elite Co. G335
> > > 
> > >  drivers/gpu/drm/i915/intel_lvds.c |   14 ++++++++++++++
> > >  1 files changed, 14 insertions(+), 0 deletions(-)
> > 
> > Patches look ok to me.  Len was curious about whether some recent ACPI
> > EC fixes will fix some of our lid detection bugs though.
> > 
> > Len, is there any particular patch or version people should try?
> 
> Unless ACPI is going to magically become more reliable at the lid
> method, I think we should abandon using it on generations where it
> fails.  See other patch I submitted -- anyone care to ack it?

Well, that was the hope.  Len said they've fixed EC bugs in the past
only to find that several ACPI methods they assumed were broken
suddenly started working....

-- 
Jesse Barnes, Intel Open Source Technology Center

Re: ACPI _LID failures

[Matthew Garrett]

On Fri, Mar 19, 2010 at 02:05:03PM -0700, Jesse Barnes wrote:

> Well, that was the hope.  Len said they've fixed EC bugs in the past
> only to find that several ACPI methods they assumed were broken
> suddenly started working....

The broken Acer was reading from the wrong registers. I think that's 
pretty strong evidence that Windows doesn't depend on lid state, 
unfortunately.

-- 
Matthew Garrett | mjg59@srcf.ucam.org