From: Pavel Machek <pavel@ucw.cz>
To: Lars Lindley <lindley@coyote.org>
Cc: gregkh@suse.de, greg@kroah.com, penberg@cs.helsinki.fi,
devel@driverdev.osuosl.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] staging: winbond: mlmetxrx.c Coding style fixes.
Date: Sat, 20 Mar 2010 01:10:48 +0100 [thread overview]
Message-ID: <20100320001048.GA1477@ucw.cz> (raw)
In-Reply-To: <1269018531-18891-1-git-send-email-lindley@coyote.org>
Hi!
And thanks for the effort.
> +u8 MLMESendFrame(struct wbsoft_priv *adapter, u8 *mmpdu, u16 len, u8 datatype)
> {
> if (adapter->sMlmeFrame.IsInUsed != PACKET_FREE_TO_USE) {
> adapter->sMlmeFrame.wNumTxMMPDUDiscarded++;
> @@ -30,17 +27,19 @@ u8 MLMESendFrame(struct wbsoft_priv * adapter, u8 *pMMPDU, u16 len, u8 DataType)
> }
> adapter->sMlmeFrame.IsInUsed = PACKET_COME_FROM_MLME;
>
> - // Keep information for sending
> - adapter->sMlmeFrame.pMMPDU = pMMPDU;
> - adapter->sMlmeFrame.DataType = DataType;
> - // len must be the last setting due to QUERY_SIZE_SECOND of Mds
> + /* Keep information for sending */
> + adapter->sMlmeFrame.pMMPDU = mmpdu;
I'm not sure if 'mmpdu' is good name. But I don't know what it stands
for, either, so...
> + adapter->sMlmeFrame.DataType = datatype;
data_type, please...
Pavel
--
(english) http://www.livejournal.com/~pavelmachek
(cesky, pictures) http://atrey.karlin.mff.cuni.cz/~pavel/picture/horses/blog.html
next prev parent reply other threads:[~2010-03-20 0:11 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-03-19 17:08 [PATCH] staging: winbond: mlmetxrx.c Coding style fixes Lars Lindley
2010-03-19 17:11 ` Lars Lindley
2010-03-20 0:10 ` Pavel Machek [this message]
2010-03-20 8:09 ` Lars Lindley
2010-03-21 12:42 ` Pekka Enberg
2010-04-28 22:57 ` Greg KH
2010-05-02 8:40 ` Lars Lindley
2010-05-03 18:47 ` Greg KH
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20100320001048.GA1477@ucw.cz \
--to=pavel@ucw.cz \
--cc=devel@driverdev.osuosl.org \
--cc=greg@kroah.com \
--cc=gregkh@suse.de \
--cc=lindley@coyote.org \
--cc=linux-kernel@vger.kernel.org \
--cc=penberg@cs.helsinki.fi \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox