From: Dan Carpenter <error27@gmail.com>
To: Richard Purdie <rpurdie@rpsys.net>
Cc: "Bruno Prémont" <bonbons@linux-vserver.org>,
"Matthew Garrett" <mjg@redhat.com>,
"Thierry Reding" <thierry.reding@avionic-design.de>,
"Emese Revfy" <re.emese@gmail.com>,
linux-kernel@vger.kernel.org, kernel-janitors@vger.kernel.org
Subject: [patch] backlight: backlight_device_register() return ERR_PTR()
Date: Sat, 20 Mar 2010 14:18:43 +0300 [thread overview]
Message-ID: <20100320111843.GS5331@bicker> (raw)
backlight_device_register() returns a valid pointer or ERR_PTR()
never NULL.
Signed-off-by: Dan Carpenter <error27@gmail.com>
diff --git a/drivers/video/backlight/adx_bl.c b/drivers/video/backlight/adx_bl.c
index b0624b9..c02b851 100644
--- a/drivers/video/backlight/adx_bl.c
+++ b/drivers/video/backlight/adx_bl.c
@@ -106,8 +106,8 @@ static int __devinit adx_backlight_probe(struct platform_device *pdev)
props.max_brightness = 0xff;
bldev = backlight_device_register(dev_name(&pdev->dev), &pdev->dev,
bl, &adx_backlight_ops, &props);
- if (!bldev) {
- ret = -ENOMEM;
+ if (IS_ERR(bldev)) {
+ ret = PTR_ERR(bldev);
goto out;
}
reply other threads:[~2010-03-20 11:18 UTC|newest]
Thread overview: [no followups] expand[flat|nested] mbox.gz Atom feed
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20100320111843.GS5331@bicker \
--to=error27@gmail.com \
--cc=bonbons@linux-vserver.org \
--cc=kernel-janitors@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mjg@redhat.com \
--cc=re.emese@gmail.com \
--cc=rpurdie@rpsys.net \
--cc=thierry.reding@avionic-design.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox