From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751932Ab0CTMYP (ORCPT ); Sat, 20 Mar 2010 08:24:15 -0400 Received: from mail-bw0-f209.google.com ([209.85.218.209]:56443 "EHLO mail-bw0-f209.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751231Ab0CTMYO (ORCPT ); Sat, 20 Mar 2010 08:24:14 -0400 DomainKey-Signature: a=rsa-sha1; c=nofws; d=gmail.com; s=gamma; h=date:from:to:cc:subject:message-id:mail-followup-to:mime-version :content-type:content-disposition:user-agent; b=QUkd5L4AFA7JvQRpKBZUBH15ajdK+KEmrp/ItCtlqhilAcXXHsSjbKZagwPQbbrRG+ /RF1cK1wPoq6O2vg46z4RJVDfQB0MvPFFPPIk8WMh/Ki3t7YQkSq9ygTcorsf3WUFzBr UU55Ui60yNqToHOGrnmz1KunoBCt6eRWvyGq0= Date: Sat, 20 Mar 2010 15:24:03 +0300 From: Dan Carpenter To: Felipe Balbi Cc: Greg Kroah-Hartman , David Brownell , Sergei Shtylyov , Ajay Kumar Gupta , linux-usb@vger.kernel.org, linux-kernel@vger.kernel.org Subject: [patch] musb: potential use after free Message-ID: <20100320122403.GC5331@bicker> Mail-Followup-To: Dan Carpenter , Felipe Balbi , Greg Kroah-Hartman , David Brownell , Sergei Shtylyov , Ajay Kumar Gupta , linux-usb@vger.kernel.org, linux-kernel@vger.kernel.org MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline User-Agent: Mutt/1.5.18 (2008-05-17) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org We assign "urb->hcpriv = qh;" a few lines down. I'm pretty sure we want it "urb->hcpriv" to be NULL not a freed value. Signed-off-by: Dan Carpenter --- Found with a static checker. I don't have the hardware to test this. diff --git a/drivers/usb/musb/musb_host.c b/drivers/usb/musb/musb_host.c index dec896e..877d20b 100644 --- a/drivers/usb/musb/musb_host.c +++ b/drivers/usb/musb/musb_host.c @@ -2042,6 +2042,7 @@ static int musb_urb_enqueue( * odd, rare, error prone, but legal. */ kfree(qh); + qh = NULL; ret = 0; } else ret = musb_schedule(musb, qh,