Re: [PATCH 4/4] Add VMware memory balloon driver

[Dmitry Torokhov <dtor@dtor-ws.eng.vmware.com>]

Hi Avi,

On Sat, Mar 20, 2010 at 06:10:57AM -0700, Avi Kivity wrote:
> On 03/19/2010 10:47 PM, Dmitry Torokhov wrote:
> > This is a virtio-based transport between VMware's hypervisor
> > and virtio_ballon driver that allows host control guest memory
> > ballooning.
> >
> >    
> 
> This is a little wierd since it's specific to the balloon driver.  The 
> virtio design is to make transport and device orthogonal so we could 
> mix'n'match any driver with any transport, but this will only work with 
> the balloon driver.  It's also 640 lines while the original balloon 
> driver is ~300.  Some of that is because you're emulating a queue that 
> doesn't really exist, IIUC.

Yes, this is corect. We have a dedicated balloon interface, so, while
trying to work with existing kernel infrastructure, we had to emulate
a virtual queue.

> 
> So while I'd love to see other hypervisors adopt virtio, I think in this 
> case it makes more sense to have your own balloon driver.
> 

Fair enough. If this is a common sentiment we'll gladly prepare our
standalone driver for submission.

Thanks.

-- 
Dmitry