From: Pavel Machek <pavel@ucw.cz>
To: Lars Lindley <lindley@coyote.org>
Cc: gregkh@suse.de, greg@kroah.com, penberg@cs.helsinki.fi,
diegoliz@gmail.com, devel@driverdev.osuosl.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] staging: winbond: mds.c: converted long if-else to switch
Date: Sun, 21 Mar 2010 21:02:55 +0100 [thread overview]
Message-ID: <20100321200255.GA1933@elf.ucw.cz> (raw)
In-Reply-To: <1268779048-21397-1-git-send-email-lindley@coyote.org>
On Tue 2010-03-16 23:37:28, Lars Lindley wrote:
> I converted the long if-else in function Mds_HeaderCopy() to a switch
> instead. It compiles fine but i don't have the hardware to test.
> Please check that I didn't do anything bad to it..
> The patch applies on top of this patch:
> Message-Id: <1268670973-6223-1-git-send-email-lindley@coyote.org>
>
> Signed-off-by: Lars Lindley <lindley@coyote.org>
ACK.
> ---
> drivers/staging/winbond/mds.c | 38 +++++++++++++++++++++++---------------
> 1 files changed, 23 insertions(+), 15 deletions(-)
>
> diff --git a/drivers/staging/winbond/mds.c b/drivers/staging/winbond/mds.c
> index ef08b51..6082fa8 100644
> --- a/drivers/staging/winbond/mds.c
> +++ b/drivers/staging/winbond/mds.c
> @@ -400,30 +400,38 @@ static void Mds_HeaderCopy(struct wbsoft_priv *adapter,
> * back rate
> */
>
> - if (ctmp1 == 108)
> + switch (ctmp1) {
> + case 108:
> ctmp2 = 7;
> - else if (ctmp1 == 96)
> + break;
> + case 96:
> ctmp2 = 6; /* Rate convert for USB */
> - else if (ctmp1 == 72)
> + break;
> + case 72:
> ctmp2 = 5;
> - else if (ctmp1 == 48)
> + break;
> + case 48:
> ctmp2 = 4;
> - else if (ctmp1 == 36)
> + break;
> + case 36:
> + case 22:
> ctmp2 = 3;
> - else if (ctmp1 == 24)
> + break;
> + case 24:
> + case 11:
> ctmp2 = 2;
> - else if (ctmp1 == 18)
> + break;
> + case 18:
> + case 4:
> ctmp2 = 1;
> - else if (ctmp1 == 12)
> + break;
> + case 12:
> ctmp2 = 0;
> - else if (ctmp1 == 22)
> - ctmp2 = 3;
> - else if (ctmp1 == 11)
> - ctmp2 = 2;
> - else if (ctmp1 == 4)
> - ctmp2 = 1;
> - else
> + break;
> + default:
> ctmp2 = 0; /* if (ctmp1 == 2) or default */
> + break;
> + }
>
> if (i == 0)
> pT01->T01_transmit_rate = ctmp2;
--
(english) http://www.livejournal.com/~pavelmachek
(cesky, pictures) http://atrey.karlin.mff.cuni.cz/~pavel/picture/horses/blog.html
next prev parent reply other threads:[~2010-03-21 20:03 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-03-16 22:37 [PATCH] staging: winbond: mds.c: converted long if-else to switch Lars Lindley
2010-03-18 16:25 ` Pekka Enberg
2010-03-21 20:02 ` Pavel Machek [this message]
2010-04-28 22:51 ` Greg KH
2010-05-02 8:35 ` Lars Lindley
2010-05-03 18:46 ` Greg KH
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20100321200255.GA1933@elf.ucw.cz \
--to=pavel@ucw.cz \
--cc=devel@driverdev.osuosl.org \
--cc=diegoliz@gmail.com \
--cc=greg@kroah.com \
--cc=gregkh@suse.de \
--cc=lindley@coyote.org \
--cc=linux-kernel@vger.kernel.org \
--cc=penberg@cs.helsinki.fi \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox