* [PATCH] drivers/net/wireless/b43/main.c:4351: Fixed coding style
@ 2010-03-22 11:52 Daniel Ngu
2010-03-22 13:40 ` Gábor Stefanik
0 siblings, 1 reply; 2+ messages in thread
From: Daniel Ngu @ 2010-03-22 11:52 UTC (permalink / raw)
To: Stefano Brivio; +Cc: linux-wireless, linux-kernel
WARNING: braces {} are not necessary for any arm of this statement
Signed-off-by: Daniel Ngu <daniel.dy.ngu@gmail.com>
---
drivers/net/wireless/b43/main.c | 5 ++---
1 files changed, 2 insertions(+), 3 deletions(-)
diff --git a/drivers/net/wireless/b43/main.c b/drivers/net/wireless/b43/main.c
index 1521b1e..14cf3bd 100644
--- a/drivers/net/wireless/b43/main.c
+++ b/drivers/net/wireless/b43/main.c
@@ -4348,11 +4348,10 @@ static int b43_wireless_core_init(struct b43_wldev *dev)
b43_set_phytxctl_defaults(dev);
/* Minimum Contention Window */
- if (phy->type == B43_PHYTYPE_B) {
+ if (phy->type == B43_PHYTYPE_B)
b43_shm_write16(dev, B43_SHM_SCRATCH, B43_SHM_SC_MINCONT, 0x1F);
- } else {
+ else
b43_shm_write16(dev, B43_SHM_SCRATCH, B43_SHM_SC_MINCONT, 0xF);
- }
/* Maximum Contention Window */
b43_shm_write16(dev, B43_SHM_SCRATCH, B43_SHM_SC_MAXCONT, 0x3FF);
--
1.5.6.5
^ permalink raw reply related [flat|nested] 2+ messages in thread* Re: [PATCH] drivers/net/wireless/b43/main.c:4351: Fixed coding style
2010-03-22 11:52 [PATCH] drivers/net/wireless/b43/main.c:4351: Fixed coding style Daniel Ngu
@ 2010-03-22 13:40 ` Gábor Stefanik
0 siblings, 0 replies; 2+ messages in thread
From: Gábor Stefanik @ 2010-03-22 13:40 UTC (permalink / raw)
To: Daniel Ngu; +Cc: Stefano Brivio, linux-wireless, linux-kernel
On Mon, Mar 22, 2010 at 12:52 PM, Daniel Ngu <daniel.dy.ngu@gmail.com> wrote:
> WARNING: braces {} are not necessary for any arm of this statement
>
> Signed-off-by: Daniel Ngu <daniel.dy.ngu@gmail.com>
> ---
> drivers/net/wireless/b43/main.c | 5 ++---
> 1 files changed, 2 insertions(+), 3 deletions(-)
>
> diff --git a/drivers/net/wireless/b43/main.c b/drivers/net/wireless/b43/main.c
> index 1521b1e..14cf3bd 100644
> --- a/drivers/net/wireless/b43/main.c
> +++ b/drivers/net/wireless/b43/main.c
> @@ -4348,11 +4348,10 @@ static int b43_wireless_core_init(struct b43_wldev *dev)
> b43_set_phytxctl_defaults(dev);
>
> /* Minimum Contention Window */
> - if (phy->type == B43_PHYTYPE_B) {
> + if (phy->type == B43_PHYTYPE_B)
> b43_shm_write16(dev, B43_SHM_SCRATCH, B43_SHM_SC_MINCONT, 0x1F);
> - } else {
> + else
> b43_shm_write16(dev, B43_SHM_SCRATCH, B43_SHM_SC_MINCONT, 0xF);
> - }
> /* Maximum Contention Window */
> b43_shm_write16(dev, B43_SHM_SCRATCH, B43_SHM_SC_MAXCONT, 0x3FF);
>
> --
> 1.5.6.5
>
> --
> To unsubscribe from this list: send the line "unsubscribe linux-wireless" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at http://vger.kernel.org/majordomo-info.html
>
Actually I believe the entire PHYTYPE_B brahcn could be removed, as we
no longer have B-PHY support in b43 anyway. But consult Michael about
this.
--
Vista: [V]iruses, [I]ntruders, [S]pyware, [T]rojans and [A]dware. :-)
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2010-03-22 13:40 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2010-03-22 11:52 [PATCH] drivers/net/wireless/b43/main.c:4351: Fixed coding style Daniel Ngu
2010-03-22 13:40 ` Gábor Stefanik
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox