From: Dan Carpenter <error27@gmail.com>
To: Lars Lindley <lindley@coyote.org>
Cc: gregkh@suse.de, greg@kroah.com, penberg@cs.helsinki.fi,
pavel@ucw.cz, devel@driverdev.osuosl.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] staging: winbond: phy_calibration.c Coding style fixes 1/2.
Date: Mon, 22 Mar 2010 17:29:24 +0300 [thread overview]
Message-ID: <20100322142924.GA23411@bicker> (raw)
In-Reply-To: <1269267447-6245-1-git-send-email-lindley@coyote.org>
On Mon, Mar 22, 2010 at 03:17:26PM +0100, Lars Lindley wrote:
> Whitespace and indentation fixes. Removed "commented away"
> code and revision comments.
> Checked with Dan Carpenters strip_whitespace.pl and diff.
> Compiles fine and .o file is identical before and after.
>
[ snip ]
> -#ifdef _DEBUG
> + /* e. The result are shown in "adc_dc_cal_i[8:0] and adc_dc_cal_q[8:0]" */
> + #ifdef _DEBUG
> hw_get_dxx_reg(phw_data, REG_OFFSET_READ, &val);
> PHY_DEBUG(("[CAL] REG_OFFSET_READ = 0x%08X\n", val));
>
> PHY_DEBUG(("[CAL] ** adc_dc_cal_i = %d (0x%04X)\n",
> - _s9_to_s32(val&0x000001FF), val&0x000001FF));
> + _s9_to_s32(val & 0x000001FF), val & 0x000001FF));
> PHY_DEBUG(("[CAL] ** adc_dc_cal_q = %d (0x%04X)\n",
> - _s9_to_s32((val&0x0003FE00)>>9), (val&0x0003FE00)>>9));
> -#endif
> + _s9_to_s32((val & 0x0003FE00) >> 9), (val & 0x0003FE00) >> 9));
> + #endif
>
#ifdef and #endif shouldn't be indented.
I'm really happy that you're using my script. It feels more relaxing to
review these when I know that no bugs were introduced.
regard,
dan carpenter
next prev parent reply other threads:[~2010-03-22 14:29 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-03-22 14:17 [PATCH] staging: winbond: phy_calibration.c Coding style fixes 1/2 Lars Lindley
2010-03-22 14:17 ` [PATCH] staging: winbond: phy_calibration.c Coding style fixes 2/2 Lars Lindley
2010-03-22 14:32 ` Dan Carpenter
2010-03-22 14:29 ` Dan Carpenter [this message]
2010-03-22 14:50 ` [PATCH] staging: winbond: phy_calibration.c Coding style fixes 1/2 Lars Lindley
2010-03-22 15:11 ` Dan Carpenter
2010-03-23 8:49 ` Pavel Machek
2010-04-28 23:36 ` Greg KH
2010-05-02 8:44 ` Lars Lindley
2010-05-03 18:47 ` Greg KH
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20100322142924.GA23411@bicker \
--to=error27@gmail.com \
--cc=devel@driverdev.osuosl.org \
--cc=greg@kroah.com \
--cc=gregkh@suse.de \
--cc=lindley@coyote.org \
--cc=linux-kernel@vger.kernel.org \
--cc=pavel@ucw.cz \
--cc=penberg@cs.helsinki.fi \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox