From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753182Ab0CVPOn (ORCPT ); Mon, 22 Mar 2010 11:14:43 -0400 Received: from mail-in-01.arcor-online.net ([151.189.21.41]:59547 "EHLO mail-in-01.arcor-online.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751630Ab0CVPOl convert rfc822-to-8bit (ORCPT ); Mon, 22 Mar 2010 11:14:41 -0400 X-DKIM: Sendmail DKIM Filter v2.8.2 mail-in-08.arcor-online.net 283452AEFF5 From: Stefan Achatz To: Jiri Kosina Subject: Re: [PATCH 2/2] Updated hid_blacklist, reformatted code and removed unused variable Date: Mon, 22 Mar 2010 16:14:38 +0100 User-Agent: KMail/1.9.9 Cc: Randy Dunlap , Stephane Chatty , Jussi Kivilinna , wylda@volny.cz, Michael Poole , simon.windows@gmail.com, Sean Hildebrand , Sid Boyce , linux-kernel@vger.kernel.org, linux-doc@vger.kernel.org, linux-input@vger.kernel.org References: <1268926981.11269.3.camel@localhost> <1269269304.2236.1.camel@localhost> In-Reply-To: MIME-Version: 1.0 Content-Type: text/plain; charset="iso-8859-1" Content-Transfer-Encoding: 8BIT Content-Disposition: inline Message-Id: <201003221614.38424.erazor_de@users.sourceforge.net> Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Am Montag, 22. März 2010 schrieb Jiri Kosina: > On Mon, 22 Mar 2010, Stefan Achatz wrote: > > Updated hid_blacklist[] so that generic driver keeps his hands off. > > Reformatted code so that definition of kone_driver and kone_devices[] > > have one initialization per line and closing brace is on extra line. > > Removed an unused variable declaration. > > > > Signed-off-by: Stefan Achatz > > --- > > drivers/hid/hid-core.c | 1 + > > drivers/hid/hid-roccat-kone.c | 15 ++++++++++----- > > 2 files changed, 11 insertions(+), 5 deletions(-) > > > > diff --git a/drivers/hid/hid-core.c b/drivers/hid/hid-core.c > > index 368fbb0..dbd6fb8 100644 > > --- a/drivers/hid/hid-core.c > > +++ b/drivers/hid/hid-core.c > > @@ -1346,6 +1346,7 @@ static const struct hid_device_id hid_blacklist[] = > > { { HID_USB_DEVICE(USB_VENDOR_ID_PETALYNX, > > USB_DEVICE_ID_PETALYNX_MAXTER_REMOTE) }, { > > HID_USB_DEVICE(USB_VENDOR_ID_QUANTA, USB_DEVICE_ID_QUANTA_OPTICAL_TOUCH) > > }, { HID_USB_DEVICE(USB_VENDOR_ID_QUANTA, > > USB_DEVICE_ID_PIXART_IMAGING_INC_OPTICAL_TOUCH_SCREEN) }, + { > > HID_USB_DEVICE(USB_VENDOR_ID_ROCCAT, USB_DEVICE_ID_ROCCAT_KONE) }, { > > HID_USB_DEVICE(USB_VENDOR_ID_SAMSUNG, USB_DEVICE_ID_SAMSUNG_IR_REMOTE) }, > > { HID_USB_DEVICE(USB_VENDOR_ID_SONY, USB_DEVICE_ID_SONY_PS3_CONTROLLER) > > }, { HID_BLUETOOTH_DEVICE(USB_VENDOR_ID_SONY, > > USB_DEVICE_ID_SONY_PS3_CONTROLLER) }, > > Thanks for the fix. I only wonder how well has the driver been tested, as > without this change it couldn't get to operate the device at all ... ? > > Thanks, Hi, As most testing was done with external module compilation on different kernel versions with generic hid compiled as internal or as module I have a script that uses the drivers sysfs bind/unbind funtionality to switch from generic hid to kone driver. Thats issued via udev and was active all the time. Have a nice day, Stefan