Re: [PATCH] PCI: create function symlinks in /sys/bus/pci/slots/N/

[Alex Chiang <achiang@hp.com>]

* Yinghai Lu <yinghai@kernel.org>:
> On Fri, Mar 19, 2010 at 2:46 PM, Jesse Barnes <jbarnes@virtuousgeek.org> wrote:
> > On Mon, 8 Mar 2010 10:24:29 -0700
> > Alex Chiang <achiang@hp.com> wrote:
> >
> >> Create convenience symlinks in sysfs, linking slots to device
> >> functions, and vice versa. These links make it easier for users to
> >> figure out which devices actually live in what slots.
> >>
> >> For example:
> >
> > Applied to linux-next, thanks.
> 
> looks this one cause
> 
> [  225.210695] calling  pci_sysfs_init+0x0/0x51 @ 1
> [  225.224774] ------------[ cut here ]------------
> [  225.228913] WARNING: at fs/sysfs/dir.c:451 sysfs_add_one+0xd9/0xf3()
> [  225.245349] Hardware name: Sun Fire x4800
> [  225.247894] sysfs: cannot create duplicate filename
> '/devices/pci0000:00/0000:00:03.0/0000:02:00.0/slot'

That's really not supposed to happen.

It means that somehow, a single pci_dev is associated with
multiple slots.

There are dev_dbg statements in pci_create_slot() that should
display which slots are getting associated with which pci_dev
during initialization.

Can you please turn those debug statements on and send the
output?

Thanks,
/ac