Re: [patch] slab: add memory hotplug support

David Rientjes
2010-03-02T21:17:12Z

On Tue, 2 Mar 2010, Andi Kleen wrote:

> The patch looks far more complicated than my simple fix.
>
> Is more complicated now better?
>

If you still believe these are "fixes," then perhaps you don't fully
understand the issue: slab completely lacked memory hotplug support when a
node is either being onlined or offlined that do not have hotadded or
hotremoved cpus. It's as simple as that.

To be fair, my patch may appear more complex because it implements full
memory hotplug support so that the nodelists are properly drained and
freed when the same memory regions you onlined for memory hot-add are now
offlined. Notice, also, how it touches no other slab code as implementing
new support for something shouldn't. There is no need for additional
hacks to be added in other slab code if you properly allocate and
initialize the nodelists for the memory being added before it is available
for use by the kernel.

If you'd test my patch out on your setup, that would be very helpful. I
can address any additional issues that you may undercover if you post the
oops while doing either memory online or offline.