public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: Greg KH <gregkh@suse.de>
To: pavan_savoy@ti.com
Cc: alan@lxorguk.ukuu.org.uk, linux-kernel@vger.kernel.org
Subject: Re: [PATCH 4/6] drivers:misc: sources for Init manager module
Date: Mon, 22 Mar 2010 14:36:29 -0700	[thread overview]
Message-ID: <20100322213629.GD420@suse.de> (raw)
In-Reply-To: <1269292756-7469-5-git-send-email-pavan_savoy@ti.com>

On Mon, Mar 22, 2010 at 04:19:14PM -0500, pavan_savoy@ti.com wrote:
> +/* structures specific for sysfs entries */
> +static struct kobj_attribute pid_attr =
> +__ATTR(pid, 0644, (void *)show_pid, (void *)store_pid);
> +
> +static struct kobj_attribute list_protocols =
> +__ATTR(protocols, 0444, (void *)show_list, NULL);

As you are creating sysfs attributes, you have to have
Documentation/ABI/ updates as well.  Please include them so we can see
what you are trying to do here.

And why "raw" attributes and not device ones?

thanks,

greg k-h

  parent reply	other threads:[~2010-03-22 21:37 UTC|newest]

Thread overview: 48+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2010-03-22 21:19 [re-worked] New ldisc for WiLink7.0 pavan_savoy
2010-03-22 21:19 ` [PATCH 1/6] serial: TTY: new ldisc for TI BT/FM/GPS chips pavan_savoy
2010-03-22 21:19   ` [PATCH 2/6] drivers:misc: Kconfig, Makefile for TI's ST ldisc pavan_savoy
2010-03-22 21:19     ` [PATCH 3/6] drivers:misc: sources for ST core pavan_savoy
2010-03-22 21:19       ` [PATCH 4/6] drivers:misc: sources for Init manager module pavan_savoy
2010-03-22 21:19         ` [PATCH 5/6] drivers:misc: sources for HCI LL PM protocol pavan_savoy
2010-03-22 21:19           ` [PATCH 6/6] drivers:misc: sources for ST header file pavan_savoy
2010-03-22 21:36         ` Greg KH [this message]
2010-03-22 22:03           ` [PATCH 4/6] drivers:misc: sources for Init manager module Savoy, Pavan
2010-03-24  2:23             ` Greg KH
2010-03-24  8:04               ` Marcel Holtmann
2010-03-24 14:54                 ` Pavan Savoy
2010-03-24 15:52                   ` Greg KH
2010-03-24 16:11                   ` Marcel Holtmann
2010-03-24 16:22                     ` Pavan Savoy
2010-03-24 16:38                       ` Marcel Holtmann
2010-03-24 16:39                         ` Randy Dunlap
2010-03-24 16:54                         ` Pavan Savoy
2010-03-24 17:03                           ` Alan Cox
2010-03-24 17:09                             ` Pavan Savoy
2010-03-24 17:26                               ` Alan Cox
2010-03-24 17:32                                 ` Pavan Savoy
2010-03-24 17:39                                   ` Alan Cox
2010-03-24 18:46                                     ` Pavan Savoy
2010-03-24 20:54                                       ` Marcel Holtmann
2010-03-24 21:03                                         ` Pavan Savoy
2010-03-24 17:15                           ` Marcel Holtmann
2010-03-24 17:42                             ` Pavan Savoy
2010-03-24 20:59                               ` Marcel Holtmann
2010-03-24 16:58                       ` Alan Cox
2010-03-24 16:56                         ` Pavan Savoy
2010-03-24 16:26                     ` Greg KH
2010-03-24 16:35                       ` Pavan Savoy
2010-03-24 16:52                         ` Greg KH
2010-03-24 17:05                           ` Pavan Savoy
2010-03-24 17:20                             ` Alan Cox
2010-03-22 21:34       ` [PATCH 3/6] drivers:misc: sources for ST core Greg KH
2010-03-23 15:24       ` Alan Cox
2010-03-22 21:34     ` [PATCH 2/6] drivers:misc: Kconfig, Makefile for TI's ST ldisc Greg KH
2010-03-22 21:35     ` Greg KH
2010-03-23  0:07       ` Tilman Schmidt
2010-03-23 15:18       ` Alan Cox
2010-03-24  2:19         ` Greg KH
2010-03-22 21:45     ` Randy Dunlap
2010-03-22 22:37       ` Savoy, Pavan
2010-03-22 22:49         ` Randy Dunlap
2010-03-23 15:20   ` [PATCH 1/6] serial: TTY: new ldisc for TI BT/FM/GPS chips Alan Cox
     [not found] <1269466536.11714.144.camel@localhost.localdomain>
2010-03-24 21:46 ` [PATCH 4/6] drivers:misc: sources for Init manager module Pavan Savoy

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20100322213629.GD420@suse.de \
    --to=gregkh@suse.de \
    --cc=alan@lxorguk.ukuu.org.uk \
    --cc=linux-kernel@vger.kernel.org \
    --cc=pavan_savoy@ti.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox