Re: [PATCH v1 1/10] Move Macro W to insn.h

Masami Hiramatsu
2010-03-22T14:10:11Z

Srikar Dronamraju wrote:
> * Masami Hiramatsu <mhiramat@redhat.com> [2010-03-20 11:50:06]:
>
>> Srikar Dronamraju wrote:
>>> Move Macro W to asm/insn.h
>>>
>>> Macro W used to know if the instructions are valid for
>>> user-space/kernel space. This macro is used by kprobes and
>>> user_bkpt. (i.e user space breakpoint assistance layer.) So moving it
>>> to a common header file asm/insn.h.
>>
>> Hmm, I don't think this shortest macro name is good to expose
>> commonly... And also, since we already have inat (instruction
>> attribute) table, we'd better expand an inat bit to indicate
>> which instruction can be probed/boosted.
>>
>
> Guess we would need three bits,
> - Instruction can be probed in kernel.

Currently, we don't have any maps for this bit.

> - Instruction can be probed in user space.
> - Instruction can be boosted.

Other two bits are ok for me :)

Thank you,

>
> Or do you have other ideas?
>
> --
> Thanks and Regards
> Srikar

--
Masami Hiramatsu
e-mail: mhiramat@redhat.com