From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752688Ab0CWLk4 (ORCPT ); Tue, 23 Mar 2010 07:40:56 -0400 Received: from fg-out-1718.google.com ([72.14.220.154]:3971 "EHLO fg-out-1718.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752024Ab0CWLkx (ORCPT ); Tue, 23 Mar 2010 07:40:53 -0400 DomainKey-Signature: a=rsa-sha1; c=nofws; d=gmail.com; s=gamma; h=date:from:to:subject:message-id:mail-followup-to:references :mime-version:content-type:content-disposition:in-reply-to :user-agent; b=YEQz930Cm3tgZxZlztzCgPLYff98gZ8vu+SP3SK9KTVY8fH4s4mtF3T2oxnRhePS2B mGmxoViykw/CNdO8VZk/01FDqvUfaoI+Jn3qIC7bKfyLGRNVkCnGL5DFIrGAiUoekN2d TdAq7GJNz34SGD89GHIWmuwzRiFeqrcPZ9bp4= Date: Tue, 23 Mar 2010 14:40:43 +0300 From: Dan Carpenter To: Mauro Carvalho Chehab , Douglas Schilling Landgraf , Robert Krakora , Nicola Soranzo , Devin Heitmueller , linux-media@vger.kernel.org, linux-kernel@vger.kernel.org, kernel-janitors@vger.kernel.org, Takashi Iwai , Andrew Morton Subject: [patch v2] em28xx: "Empia Em28xx Audio" too long Message-ID: <20100323114043.GY21571@bicker> Mail-Followup-To: Dan Carpenter , Mauro Carvalho Chehab , Douglas Schilling Landgraf , Robert Krakora , Nicola Soranzo , Devin Heitmueller , linux-media@vger.kernel.org, linux-kernel@vger.kernel.org, kernel-janitors@vger.kernel.org, Takashi Iwai , Andrew Morton References: <20100319114825.GO5331@bicker> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20100319114825.GO5331@bicker> User-Agent: Mutt/1.5.18 (2008-05-17) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org card->driver is 15 characters and a NULL. The original code goes past the end of the array. Signed-off-by: Dan Carpenter --- V2: Takashi Iwai asked me to change the space to a hyphen since this is used as an identifier in alsa-lib. diff --git a/drivers/media/video/em28xx/em28xx-audio.c b/drivers/media/video/em28xx/em28xx-audio.c index bd78338..e182abf 100644 --- a/drivers/media/video/em28xx/em28xx-audio.c +++ b/drivers/media/video/em28xx/em28xx-audio.c @@ -491,7 +491,7 @@ static int em28xx_audio_init(struct em28xx *dev) strcpy(pcm->name, "Empia 28xx Capture"); snd_card_set_dev(card, &dev->udev->dev); - strcpy(card->driver, "Empia Em28xx Audio"); + strcpy(card->driver, "Em28xx-Audio"); strcpy(card->shortname, "Em28xx Audio"); strcpy(card->longname, "Empia Em28xx Audio");