public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: Andrew Morton <akpm@linux-foundation.org>
To: Tobias Klauser <tklauser@distanz.ch>
Cc: linux-serial@vger.kernel.org, gregkh@suse.de,
	nios2-dev@sopc.et.ntust.edu.tw, linux-kernel@vger.kernel.org
Subject: Re: [PATCHv3 2/2] serial: Add driver for the Altera UART
Date: Tue, 23 Mar 2010 14:54:59 -0700	[thread overview]
Message-ID: <20100323145459.9894b1e6.akpm@linux-foundation.org> (raw)
In-Reply-To: <a596efa5dc6130a27d045ea24174c792ee2f0bb4.1267807169.git.klto@zhaw.ch>

On Fri,  5 Mar 2010 17:52:23 +0100
Tobias Klauser <tklauser@distanz.ch> wrote:

> +	sigs |= (altera_uart_getppdcd(port->line) ? TIOCM_CD : 0);
> +	sigs |= (altera_uart_getppdtr(port->line) ? TIOCM_DTR : 0);

We seem to be missing a few things here.

drivers/serial/altera_uart.c: In function 'altera_uart_get_mctrl':
drivers/serial/altera_uart.c:100: error: implicit declaration of function 'altera_uart_getppdcd'
drivers/serial/altera_uart.c:101: error: implicit declaration of function 'altera_uart_getppdtr'
drivers/serial/altera_uart.c: In function 'altera_uart_set_mctrl':
drivers/serial/altera_uart.c:114: error: implicit declaration of function 'altera_uart_setppdtr'                                                                                                                                                                              

  reply	other threads:[~2010-03-23 21:55 UTC|newest]

Thread overview: 14+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2010-03-05 16:52 [PATCHv3 0/2] serial: Drivers for Altera UARTs Tobias Klauser
2010-03-05 16:52 ` [PATCHv3 1/2] serial: Add driver for the Altera JTAG UART Tobias Klauser
2010-03-12 20:48   ` Andrew Morton
2010-03-15 10:20     ` Tobias Klauser
2010-03-15 10:24       ` [Nios2-dev] " waltergoossens
2010-03-16  0:47     ` Thomas Chou
2010-03-05 16:52 ` [PATCHv3 2/2] serial: Add driver for the Altera UART Tobias Klauser
2010-03-23 21:54   ` Andrew Morton [this message]
2010-03-24  6:47     ` Tobias Klauser
2010-03-24 11:05       ` Andrew Morton
2010-03-24 16:24         ` Tobias Klauser
2010-03-25  0:54           ` Thomas Chou
2010-03-29 13:29             ` Tobias Klauser
2010-03-30  0:18               ` Thomas Chou

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20100323145459.9894b1e6.akpm@linux-foundation.org \
    --to=akpm@linux-foundation.org \
    --cc=gregkh@suse.de \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-serial@vger.kernel.org \
    --cc=nios2-dev@sopc.et.ntust.edu.tw \
    --cc=tklauser@distanz.ch \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox