From: Thomas Renninger <trenn@suse.de>
To: Dan Carpenter <error27@gmail.com>
Cc: "Len Brown" <lenb@kernel.org>,
"Darrick J. Wong" <djwong@us.ibm.com>,
"Andrew Morton" <akpm@linux-foundation.org>,
"Márton Németh" <nm127@freemail.hu>,
"Lin Ming" <ming.m.lin@intel.com>,
linux-acpi@vger.kernel.org, linux-kernel@vger.kernel.org,
kernel-janitors@vger.kernel.org
Subject: Re: [patch] power_meter: acpi_device_class "power_meter_resource" too long
Date: Tue, 23 Mar 2010 17:26:07 +0100 [thread overview]
Message-ID: <201003231726.07480.trenn@suse.de> (raw)
In-Reply-To: <20100319114920.GP5331@bicker>
On Friday 19 March 2010 12:49:20 Dan Carpenter wrote:
> acpi_device_class can only be 19 characters and a NULL terminator.
>
> The current code has a buffer overflow in acpi_power_meter_add():
> strcpy(acpi_device_class(device), ACPI_POWER_METER_CLASS);
Sounds as if it would be worth to add:
CC: stable@kernel.org
?
Same for processor_aggregator.
Thomas
>
> Signed-off-by: Dan Carpenter <error27@gmail.com>
> ---
> Feel free to change the name to anything you like.
>
> diff --git a/drivers/acpi/power_meter.c b/drivers/acpi/power_meter.c
> index 834c5af..31baa1e 100644
> --- a/drivers/acpi/power_meter.c
> +++ b/drivers/acpi/power_meter.c
> @@ -34,7 +34,7 @@
> #define ACPI_POWER_METER_NAME "power_meter"
> ACPI_MODULE_NAME(ACPI_POWER_METER_NAME);
> #define ACPI_POWER_METER_DEVICE_NAME "Power Meter"
> -#define ACPI_POWER_METER_CLASS "power_meter_resource"
> +#define ACPI_POWER_METER_CLASS "pwr_meter_resource"
>
> #define NUM_SENSORS 17
>
> --
prev parent reply other threads:[~2010-03-23 16:26 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-03-19 11:49 [patch] power_meter: acpi_device_class "power_meter_resource" too long Dan Carpenter
2010-03-22 18:13 ` Darrick J. Wong
2010-03-23 16:26 ` Thomas Renninger [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=201003231726.07480.trenn@suse.de \
--to=trenn@suse.de \
--cc=akpm@linux-foundation.org \
--cc=djwong@us.ibm.com \
--cc=error27@gmail.com \
--cc=kernel-janitors@vger.kernel.org \
--cc=lenb@kernel.org \
--cc=linux-acpi@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=ming.m.lin@intel.com \
--cc=nm127@freemail.hu \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox