From: Greg KH <gregkh@suse.de>
To: Marcel Holtmann <marcel@holtmann.org>
Cc: pavan_savoy@ti.com, alan@lxorguk.ukuu.org.uk,
linux-kernel@vger.kernel.org, pavan_savoy@yahoo.co.in
Subject: Re: [PATCH 1/7] serial: TTY: new ldisc for TI BT/FM/GPS chips
Date: Tue, 23 Mar 2010 19:48:30 -0700 [thread overview]
Message-ID: <20100324024830.GA4642@suse.de> (raw)
In-Reply-To: <1269397490.11714.104.camel@localhost.localdomain>
On Tue, Mar 23, 2010 at 07:24:50PM -0700, Marcel Holtmann wrote:
> > +#define N_TI_WL 20 /* for TI's WL connectivity chips */
> >
> > /*
> > * This character is the same as _POSIX_VDISABLE: it cannot be used as
>
> why is this even targeting staging. I prefer if we have proper review
> cycles and get this reviewed this way. This looks like more a shortcut
> to get things into the kernel than actually spending the effort to clean
> things up.
>
> If this would be just a driver, I wouldn't care, but it tries to assign
> official numbers for a line discipline and clearly collides with other
> peoples work that are going the proper upstream review cycles.
>
> Greg, I would like to see the rule that if it touches files outside of
> drivers/staging/ then it is not eligible for staging.
That is a rule already :)
See my complaint about this a few minutes ago.
thanks,
greg k-h
next prev parent reply other threads:[~2010-03-24 2:49 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-03-23 20:41 [v3] New ldisc for WiLink7.0 pavan_savoy
2010-03-23 20:41 ` [PATCH 1/7] serial: TTY: new ldisc for TI BT/FM/GPS chips pavan_savoy
2010-03-23 20:41 ` [PATCH 2/7] drivers:staging: Kconfig, Makefile for TI's ST ldisc pavan_savoy
2010-03-23 20:41 ` [PATCH 3/7] drivers:staging: sources for ST core pavan_savoy
2010-03-23 20:41 ` [PATCH 4/7] drivers:staging: sources for Init manager module pavan_savoy
2010-03-23 20:41 ` [PATCH 5/7] drivers:staging: sources for HCI LL PM protocol pavan_savoy
2010-03-23 20:41 ` [PATCH 6/7] drivers:staging: sources for ST header file pavan_savoy
2010-03-23 20:41 ` [PATCH 7/7] Documentation/ABI: for N_TI_SHARED ldisc pavan_savoy
2010-03-24 2:29 ` Greg KH
2010-03-24 2:28 ` [PATCH 2/7] drivers:staging: Kconfig, Makefile for TI's ST ldisc Greg KH
2010-03-24 2:30 ` Greg KH
2010-03-24 2:24 ` [PATCH 1/7] serial: TTY: new ldisc for TI BT/FM/GPS chips Marcel Holtmann
2010-03-24 2:48 ` Greg KH [this message]
2010-03-24 2:28 ` Greg KH
2010-03-24 8:43 ` Alan Cox
2010-03-24 15:49 ` Greg KH
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20100324024830.GA4642@suse.de \
--to=gregkh@suse.de \
--cc=alan@lxorguk.ukuu.org.uk \
--cc=linux-kernel@vger.kernel.org \
--cc=marcel@holtmann.org \
--cc=pavan_savoy@ti.com \
--cc=pavan_savoy@yahoo.co.in \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox