Re: [PATCH 1/7] serial: TTY: new ldisc for TI BT/FM/GPS chips

[Greg KH <gregkh@suse.de>]

On Wed, Mar 24, 2010 at 08:43:07AM +0000, Alan Cox wrote:
> On Tue, 23 Mar 2010 19:28:03 -0700
> Greg KH <gregkh@suse.de> wrote:
> 
> > On Tue, Mar 23, 2010 at 03:41:09PM -0500, pavan_savoy@ti.com wrote:
> > > From: Pavan Savoy <pavan_savoy@ti.com>
> > > 
> > > A new N_TI_WL line discipline added for TI BT/FM/GPS
> > > combo chips which make use of same TTY to communicate
> > > with chip. This is to be made use of individual protocol
> > > BT/FM/GPS drivers.
> > > 
> > > Signed-off-by: Pavan Savoy <pavan_savoy@ti.com>
> > > ---
> > >  include/linux/tty.h |    3 ++-
> > 
> > Staging code needs to be completly self-contained in the drivers/staging
> > directory.  Is there any way to do this without touching this file?
> 
> Put the N_TI_WL into a staging header, and bump the number of ldiscs as a
> separate non staging patch - we should probably simply bump it a bit
> anyway to leave room for experimental work using a built kernel image.
> There is no requirement that the number of ldiscs matches up to the last
> ldisc assigned.

That sounds good to me.

thanks,

greg k-h