From: Oleg Nesterov <oleg@redhat.com>
To: Andrew Morton <akpm@linux-foundation.org>
Cc: Alan Cox <alan@linux.intel.com>, Ingo Molnar <mingo@elte.hu>,
Peter Zijlstra <peterz@infradead.org>,
Roland McGrath <roland@redhat.com>,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH -mm] signals-clear-signal-tty-when-the-last-thread-exits.fix
Date: Wed, 24 Mar 2010 17:02:42 +0100 [thread overview]
Message-ID: <20100324160242.GA32557@redhat.com> (raw)
In-Reply-To: <20100324074149.8d4e96e6.akpm@linux-foundation.org>
On 03/24, Andrew Morton wrote:
>
> > - struct tty_struct *tty;
> > + struct tty_struct *tty = NULL; /* supress gcc warning */
>
> uninitialized_var() is a neater way.
Aha, indeed.
Will resend soon...
Oleg.
next prev parent reply other threads:[~2010-03-24 16:04 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-03-19 18:40 [PATCH 2/3] clear signal->tty when the last thread exits Oleg Nesterov
2010-03-24 14:23 ` [PATCH -mm] signals-clear-signal-tty-when-the-last-thread-exits.fix Oleg Nesterov
2010-03-24 11:41 ` Andrew Morton
2010-03-24 16:02 ` Oleg Nesterov [this message]
2010-03-24 16:42 ` Oleg Nesterov
2010-04-08 2:20 ` [PATCH 2/3] clear signal->tty when the last thread exits Roland McGrath
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20100324160242.GA32557@redhat.com \
--to=oleg@redhat.com \
--cc=akpm@linux-foundation.org \
--cc=alan@linux.intel.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@elte.hu \
--cc=peterz@infradead.org \
--cc=roland@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox